From patchwork Wed Jan 29 11:54:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13953673 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA4D0C0218D for ; Wed, 29 Jan 2025 11:54:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2500710E7C0; Wed, 29 Jan 2025 11:54:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="bwRzM+2u"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF33B10E7C0 for ; Wed, 29 Jan 2025 11:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738151663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=herznK9N3+37fO8/yUnjjPI+kU1qrhYMSQrHDNQrbI8=; b=bwRzM+2uHt+qpeD9N2r4zABp2V7qI3JuItDa+rgIv2ZxuThcC/qQb5dBpcM88ZQ5s0ap2x Yt+/7i5b+Vrmqr7fMlXFG+AGyO+gOiIMeAlO/IEKTTAPIEybzSjTCZLb3CUsEbzs4DFULI OBxlXMAKhtEm3syBc58h2UDvsnPdjyo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-kQzVyX3mODuqH_jS2vpXdA-1; Wed, 29 Jan 2025 06:54:21 -0500 X-MC-Unique: kQzVyX3mODuqH_jS2vpXdA-1 X-Mimecast-MFC-AGG-ID: kQzVyX3mODuqH_jS2vpXdA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43625ceae52so36533915e9.0 for ; Wed, 29 Jan 2025 03:54:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738151660; x=1738756460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=herznK9N3+37fO8/yUnjjPI+kU1qrhYMSQrHDNQrbI8=; b=pDgCWpTdWX5OxmK/mGNiXwJagvHfKmPRwsejZRRJgh48jcWd+wy8AO12LQP+op9s5U OWX2rTz4GD1imla5RqNHzPGjIUmQK6dNstqpI092y6EgmW1gTMtYvVplit3Mrewohebu HnGDYzsllGLOQMSggnGmD02G6htn/9G6ba67OG2dxUM/v39WJgLyPxsnejYeUYbkjTgx 8OaSFlStZiTJgsjcCi8YATJJzd4/PLNEGl9C2cfmvlq6CKf8iUj8CJBNRIdnf/sCQSGO FYwksDtYeQfj/hgTyzDftgTiREz0KDNEyJC/9XHoyugpUoZXVaT53LhdgFRfDY/7ouwK 2dyg== X-Forwarded-Encrypted: i=1; AJvYcCVUm9Vb0JQnmPVDMkz49qgS7BD4lqdozbob/OFvT7/A14DoS0Rn1S8G88vtW88819BILBNMBOd+krg=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzh+9QHAqrYMyxILOCRg9RGwcNI8ojf4VQwRdFhv3GFtYedEm+F +BwfSQEdJt6cKfAGNFNju6dKubmh/jQKS/ZFSQsR1pafjm7Q2Lbn5r4rwTfL95zZL5U9YvtNXwF 2JPC4Q37K35xk6n00gos4Tbn7DbRQb6BOVqcAg4DEzoRASZyhNki8IjPPhsA1krfG4A== X-Gm-Gg: ASbGncu9cm/AxDluHjgDktxBlcV+iJPIePGTBq8C4E6jKYQfqi5LfwnNEcjZZPYR68D ysR2EPvhEdzRSe2r738OSZctJ3FOJA32C0H+fubddzS3+BR1JyRBSHgyCAVePoPDzLcDNnaPyEG 3YXCu+8l9DTsu/WcXXHUw37gyb56vK4mtdXPnJwsppLDA6RFVkBFDISpPem0swONbHK3v85K39D d6wyzcseBpUYu8OWk+mUEmSfjJujRRDsOIA2uDpX4Gi9HRQCFAOqvKbezHh3l38JxUr7LYFB7LN CWMWOM4+74AEFHrGi+fwGPPOBYd7/nO0pC5Qk6maSu+VWPWQ9EhuPz9zKxfD2Tvemg== X-Received: by 2002:a05:600c:5486:b0:433:c76d:d57e with SMTP id 5b1f17b1804b1-438dc3a40d3mr26190425e9.5.1738151660681; Wed, 29 Jan 2025 03:54:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEopxoArzHie066mjWjUvNKTSc/02V79PTjUrPj2QcjbwdMpR1m12X2+qvEI4pAjYXanIEeWA== X-Received: by 2002:a05:600c:5486:b0:433:c76d:d57e with SMTP id 5b1f17b1804b1-438dc3a40d3mr26190115e9.5.1738151660040; Wed, 29 Jan 2025 03:54:20 -0800 (PST) Received: from localhost (p200300cbc7053b0064b867195794bf13.dip0.t-ipconnect.de. [2003:cb:c705:3b00:64b8:6719:5794:bf13]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-438dcbbc52dsm21427725e9.0.2025.01.29.03.54.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 03:54:18 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, David Hildenbrand , Andrew Morton , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe , stable@vger.kernel.org Subject: [PATCH v1 02/12] mm/rmap: reject hugetlb folios in folio_make_device_exclusive() Date: Wed, 29 Jan 2025 12:54:00 +0100 Message-ID: <20250129115411.2077152-3-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250129115411.2077152-1-david@redhat.com> References: <20250129115411.2077152-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pltkpYzG0yXAW0X1S2OdDuIHZLrI06CGsjG1bskNVTM_1738151661 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Even though FOLL_SPLIT_PMD on hugetlb now always fails with -EOPNOTSUPP, let's add a safety net in case FOLL_SPLIT_PMD usage would ever be reworked. In particular, before commit 9cb28da54643 ("mm/gup: handle hugetlb in the generic follow_page_mask code"), GUP(FOLL_SPLIT_PMD) would just have returned a page. In particular, hugetlb folios that are not PMD-sized would never have been prone to FOLL_SPLIT_PMD. hugetlb folios can be anonymous, and page_make_device_exclusive_one() is not really prepared for handling them at all. So let's spell that out. Fixes: b756a3b5e7ea ("mm: device exclusive memory access") Cc: Signed-off-by: David Hildenbrand Reviewed-by: Alistair Popple --- mm/rmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index c6c4d4ea29a7..17fbfa61f7ef 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -2499,7 +2499,7 @@ static bool folio_make_device_exclusive(struct folio *folio, * Restrict to anonymous folios for now to avoid potential writeback * issues. */ - if (!folio_test_anon(folio)) + if (!folio_test_anon(folio) || folio_test_hugetlb(folio)) return false; rmap_walk(folio, &rwc);