| Message ID | 20250130-mt8370-enable-gpu-v2-2-c154d0815db5@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mali GPU support for Mediatek MT8370 SoC | expand |
On 30/01/2025 13:31, Louis-Alexis Eyraud wrote: > Add a compatible for the MediaTek MT8370 SoC, with an > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), > with the same platform data as MT8186 (one regulator, two power > domains). > > Reviewed-by: Steven Price <steven.price@arm.com> > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 0f3935556ac761adcd80197d87e8e478df436fd5..7b7e9f6f620659a7fdcb5d907ebc4f01eca876e0 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -859,6 +859,7 @@ static const struct of_device_id dt_match[] = { > { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data }, > { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data }, > { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, > + { .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8186_data }, Nothing improved here. All my previous comments still stand. Best regards, Krzysztof
On Thu, 2025-01-30 at 14:17 +0100, Krzysztof Kozlowski wrote: > On 30/01/2025 13:31, Louis-Alexis Eyraud wrote: > > Add a compatible for the MediaTek MT8370 SoC, with an > > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), > > with the same platform data as MT8186 (one regulator, two power > > domains). > > > > Reviewed-by: Steven Price <steven.price@arm.com> > > Signed-off-by: Louis-Alexis Eyraud > > <louisalexis.eyraud@collabora.com> > > --- > > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c > > b/drivers/gpu/drm/panfrost/panfrost_drv.c > > index > > 0f3935556ac761adcd80197d87e8e478df436fd5..7b7e9f6f620659a7fdcb5d907 > > ebc4f01eca876e0 100644 > > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > > @@ -859,6 +859,7 @@ static const struct of_device_id dt_match[] = { > > { .compatible = "mediatek,mt8186-mali", .data = > > &mediatek_mt8186_data }, > > { .compatible = "mediatek,mt8188-mali", .data = > > &mediatek_mt8188_data }, > > { .compatible = "mediatek,mt8192-mali", .data = > > &mediatek_mt8192_data }, > > + { .compatible = "mediatek,mt8370-mali", .data = > > &mediatek_mt8186_data }, > > Nothing improved here. All my previous comments still stand. > > Best regards, > Krzysztof Hi, I'll reword this commit message in V3 to add that despite GPU architecture difference (making them being not compatible), the MT8186 platform data can still be used for MT8370 too because it only describes supplies, domains and enablement of power management features in the driver. Regards, Louis-Alexis
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index 0f3935556ac761adcd80197d87e8e478df436fd5..7b7e9f6f620659a7fdcb5d907ebc4f01eca876e0 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -859,6 +859,7 @@ static const struct of_device_id dt_match[] = { { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data }, { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data }, { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, + { .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8186_data }, {} }; MODULE_DEVICE_TABLE(of, dt_match);