From patchwork Sun Feb 9 03:21:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13966606 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71984C0219D for ; Sun, 9 Feb 2025 03:21:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E268410E477; Sun, 9 Feb 2025 03:21:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="FJV7Y0mh"; dkim-atps=neutral Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DEDA10E477 for ; Sun, 9 Feb 2025 03:21:42 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-540215984f0so3515041e87.1 for ; Sat, 08 Feb 2025 19:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739071301; x=1739676101; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ku0sYwA6Z9dPRMZKA3dFauq5bkh59hsd6mNrzYvKW4g=; b=FJV7Y0mh3m4qq1SS4fFPEGZAyc2j6M0kavaojgmD+dltdkhuztevyH9MMj4mPN5O6q n8l7ipJMQcJP4a+jo8MrsrsCz/Ng4BAXM0MvAMHJptwxrrGjJO+/Pez9YMG9Bsp1PQZW 4wxM9DZ5pwLXL8omnQBK7Nhj07qV17Fiy9B5GFVdYFVV/gXHvY7v2QHMlnRA+3l2102z i8VMRek9RNfJ70LqAzU4ppRh57nP5RPrU/S+1D1gfVua2l+lqildUCvax8C/OkW2B9sl +gMONyZI/Y1MSX3fe1utAyAtMk7TUHxdqcVw65EP6LEfMAWidgotax0dqliX2tNXx00B IITA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739071301; x=1739676101; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ku0sYwA6Z9dPRMZKA3dFauq5bkh59hsd6mNrzYvKW4g=; b=W6kGzYn9G/1Yu04Zzfx6/9lkASbrsx2ML9SZk/91ntTdvqukuREX8a+wzRLyhRfa9x FKtCiK2JYpzGkRfNrbRaMBvyus5q9L0BS4QeJ6x8BYQ32V9leRw6h8Nn3g72EwI61U10 XrTOfDwOagZZHKzj/jRDohEst0i2uAwivYM5HhPcpAePO1xhj1uyHGeMUyO8+x5Sqkpr oBm8PI4vH4eCuiJPCVTiY9hAhvmWh5/qbXgXCbrU/Gbc3IPBGrbRE8NxJs6BMHnSvNEz kNoYaFHHl+5cu80KBJV60IooT7rKJrd5hY7EYyxX03HpsdkIiB3ofniKmCupZ63FRGqo moDw== X-Forwarded-Encrypted: i=1; AJvYcCXwIxqlFYQB4VugHxAjJtxnzUKsWkq3cbOW4YRQEGaHVtKzRQ7aGQJwTfZvd6njI1xiNZcn3Y3/Ia4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzBi2B9oWEnVq/GBiIlNKJaNIgq9YGtG+q80MpgmZMF2vsbCZzX +l1nzvkH35ez7Cycwb5vGmcam6LwiGWRQ6Vv6p5JAYhLSjpPta416GJdWjji8U0= X-Gm-Gg: ASbGncsdahkxTvESqEC33cjP6iSWTXgF2phwtmQc0gab2frhc4Hj/RK2TUZ4LTROoE4 e73QfAHkHhG1qSVQ5aU9xCWD3kRlnb4tjBuVSho0RiGpnpvUe0cE2e1v4HjSZqgEzYD9EoLuD2i 4ZNaqhEHeB4hOzdXyn8SoeUUvW2S4Xr2urTjqeFpcgidtj47BgGeTZHNzK+wDZoZYBvxJYR/ola qgoq4rRvLJ+5D5tgn3ftFVT3XQ00vGKaC5gByexZlJRx9l1I84Fd1j5G+vK9NFoP3n5I4Pmz4zL 3nfO2x52K1704bBu/5YWOa4= X-Google-Smtp-Source: AGHT+IGePwGd1RebmPrp1HI9qS1UxYaPhesybFi+M1gkvl3CAIFaQZZ5SKnQHqSf6VHb6FtMneT2Xg== X-Received: by 2002:a05:6512:1196:b0:544:1407:4e9e with SMTP id 2adb3069b0e04-54414aba30bmr2620571e87.29.1739071300792; Sat, 08 Feb 2025 19:21:40 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54505e41c63sm279711e87.148.2025.02.08.19.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 19:21:39 -0800 (PST) From: Dmitry Baryshkov Date: Sun, 09 Feb 2025 05:21:17 +0200 Subject: [PATCH v5 7/8] drm/msm/dpu: drop core_clk_rate overrides from _dpu_core_perf_calc_crtc MIME-Version: 1.0 Message-Id: <20250209-dpu-perf-rework-v5-7-87e936cf3004@linaro.org> References: <20250209-dpu-perf-rework-v5-0-87e936cf3004@linaro.org> In-Reply-To: <20250209-dpu-perf-rework-v5-0-87e936cf3004@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Stephen Boyd , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1474; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=emVhsAcPMXJo9jthW8kjkV7unV6UYdXutY3krP5kLuA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnqB8xGtaeqDuQnMeiiB+yFOQgI/3mzcHxIa549 qctshj8PxuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ6gfMQAKCRCLPIo+Aiko 1ZTXB/9tOXIbVITqUa0mxZ8LeScVG3PhyG4XYqZMYA31A8WayXVwL0iwO4z46BRMll56qDanQZY vb7kMze651Slxw8udpY5UsFJvTDGor82C1W2cOrn23AIYYTyx4p1uktvIgN06ADzBIoLCLl3B9r QoWqHsI2sea/zc/1Ezwl61bMm5uNGVAjH4FG9qKBtUEKg0V+iEqnUHx8gGPWqRmUMWzSBIBGUZe 1eznQ8Q2LXrzksspjIomR4OtIS9+1C+mJhsHxUK03YchuANpWIA+QvjgIN4dvGID4+AfTwHBoV7 00E2/FtsbwAWf6NxIVsI746DRodAdkR+3tXTtCHHtzaMZyU6 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" core_clk_rate override is handled in _dpu_core_perf_get_core_clk_rate(). Drop imperfect duplicating code from _dpu_core_perf_calc_crtc(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c index 70f43e8359caee2082f2ca9944a17a6a20aa3d49..c8e20be08aa83c8bdd70065643b46676eeed610f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c @@ -123,16 +123,14 @@ static void _dpu_core_perf_calc_crtc(const struct dpu_core_perf *core_perf, if (core_perf->perf_tune.mode == DPU_PERF_MODE_MINIMUM) { perf->bw_ctl = 0; perf->max_per_pipe_ib = 0; - perf->core_clk_rate = 0; } else if (core_perf->perf_tune.mode == DPU_PERF_MODE_FIXED) { perf->bw_ctl = core_perf->fix_core_ab_vote * 1000ULL; perf->max_per_pipe_ib = core_perf->fix_core_ib_vote; - perf->core_clk_rate = core_perf->fix_core_clk_rate; } else { perf->bw_ctl = _dpu_core_perf_calc_bw(perf_cfg, crtc); perf->max_per_pipe_ib = perf_cfg->min_dram_ib; - perf->core_clk_rate = _dpu_core_perf_calc_clk(perf_cfg, crtc, state); } + perf->core_clk_rate = _dpu_core_perf_calc_clk(perf_cfg, crtc, state); DRM_DEBUG_ATOMIC( "crtc=%d clk_rate=%llu core_ib=%u core_ab=%u\n",