diff mbox series

[2/4] dt-bindings: display/msm: Add stream 1 pixel clock for QCS8300

Message ID 20250212-mst_qcs8300-v1-2-38a8aa08394b@quicinc.com (mailing list archive)
State New, archived
Headers show
Series Add MST support for qcs8300 platform | expand

Commit Message

Yongxing Mou Feb. 12, 2025, 7:12 a.m. UTC 
Support mst for qcs8300 and add the stream 1 clock support in the mdss
dt-bindings.

Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>
---
 .../devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Krzysztof Kozlowski Feb. 12, 2025, 8:34 a.m. UTC | #1 
On 12/02/2025 08:12, Yongxing Mou wrote:
> Support mst for qcs8300 and add the stream 1 clock support in the mdss
> dt-bindings.
> 
> Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com>

Your patchset leads to warnings - it is non-bisectable.

Fix original code, don't post buggy patches just to fix them immediately.

> 


Best regards,
Krzysztof
Yongxing Mou Feb. 19, 2025, 10 a.m. UTC | #2 
On 2025/2/12 16:34, Krzysztof Kozlowski wrote:
> Your patchset leads to warnings - it is non-bisectable.
> 
> Fix original code, don't post buggy patches just to fix them immediately.

Got it. Thanks for the reminder, won't do it again.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
index eb7f36387f748793ebf662baded4a13a61b3ce39..610742ceebf8ee5e140a409bfeb92d9f43085214 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,qcs8300-mdss.yaml
@@ -53,7 +53,6 @@  patternProperties:
       compatible:
         items:
           - const: qcom,qcs8300-dp
-          - const: qcom,sm8650-dp
 
 required:
   - compatible
@@ -164,7 +163,7 @@  examples:
         };
 
         displayport-controller@af54000 {
-            compatible = "qcom,qcs8300-dp", "qcom,sm8650-dp";
+            compatible = "qcom,qcs8300-dp";
 
             pinctrl-0 = <&dp_hot_plug_det>;
             pinctrl-names = "default";
@@ -181,15 +180,18 @@  examples:
                      <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
                      <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
                      <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
-                     <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>;
+                     <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
+                     <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK>;
             clock-names = "core_iface",
                           "core_aux",
                           "ctrl_link",
                           "ctrl_link_iface",
-                          "stream_pixel";
+                          "stream_pixel",
+                          "stream_1_pixel";
             assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
-                              <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>;
-            assigned-clock-parents = <&mdss_edp_phy 0>, <&mdss_edp_phy 1>;
+                              <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>,
+                              <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK_SRC>;
+            assigned-clock-parents = <&mdss_edp_phy 0>, <&mdss_edp_phy 1>, <&mdss_edp_phy 1>;
             phys = <&mdss_edp_phy>;
             phy-names = "dp";
             operating-points-v2 = <&dp_opp_table>;