From patchwork Mon Feb 17 14:04:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 13977900 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 544BCC021AD for ; Mon, 17 Feb 2025 14:05:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D718710E4D2; Mon, 17 Feb 2025 14:04:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.b="N71tKTwH"; dkim-atps=neutral Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C1C110E4D3; Mon, 17 Feb 2025 14:04:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lqI7tRq9WKOwiU2avy/i0aXSPqomDbRSYk3sj2blaESVdvxUh11pFB7uXbJ44+5tvB2e0IdN2vnJ/OrnA6fCwQ5MLjh1EhUsJJ0cmA3Cpl5DX7/S/djHIUu51UrZeRoGoPu17WnD74hma1g8Vf7rjgiu51pLDQYnG6f7vxnUMT9D6rIJIpEQcqvw1b7bVPgWNbXnueBShJIH5yQcFLkka/oYLN9OJ41f92UlArhINcX1YC/JzwcvBjjirCHuE6w0HJIaLwr6KH9VRrjFAFeMPRYm7fXOTRtHC2XMjkLYYpERdxupYfPm/jOMvBp4aqPWdDlfy4fuCTWbHj4Iae2OvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0giXkbfZ97KCjGxEv6E3orDPpMhefyg3MZB6wGUVyZU=; b=OCS3w/aKNWSFqzYNkgY4UBh+IWm+UF+iI7cddfdHMFpYq+j9d7b5a4jJDDJy+FpPKDPFfstsUMW+lQGNUqGfy3rzwq2MV0kRDoxNDkh1f7xOFCrS2mQGQ+GojwvjmT0nuj+TIF4/3cV/IZTBTd1DaUIRl+oNstthLrt8xQtwGAwdN14RMhbJHoaB9SnDwEWaHWE35odGPC3f12l4bub6YI0rcGRlF+osbIRIUCqrxeiyY9PIb/430St7zdgiQUAmYojOCVN4UYa1qi0nb0gOJvYuVEjwSOSnZu2AQ2MLT07xe+B05Ypz8VvO+tmQD8+zV7d8FaWNqqca7J6vdWUOOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0giXkbfZ97KCjGxEv6E3orDPpMhefyg3MZB6wGUVyZU=; b=N71tKTwHE3jAqtiXzc4PuN7swJWQUCaFFub9whQVP8awHWZHnSgvNWEDf/IYe0YYd59CJPqRYhcoDcps+yhnoqAmByHsO9CS9+SL86Lhr+Saon7q/XHcvumKeTTqGQMjGyQbA3zwokO1sisS9/3SXecWcAFHmCr2j/OpnGa2BL6o4G8VkS+Dz1HFD1Ml4uXwXHqG+tA1Y7axJt61u9DAds/nPRkluVBkeWJoUsV4luKaShe1vUnTQJJ1ShNikjMftFHyQje89Zcn3iTmO8Q3iRMLGuimU0lxilMVjm4+HFdjInzoUC+eHWbIpB0ohH2mJCYx1CTQwfUh9lPdUOMPdQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by MN2PR12MB4208.namprd12.prod.outlook.com (2603:10b6:208:1d0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 14:04:54 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::6e37:569f:82ee:3f99%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 14:04:54 +0000 From: Alexandre Courbot Date: Mon, 17 Feb 2025 23:04:46 +0900 Subject: [PATCH RFC 1/3] rust: add useful ops for u64 Message-Id: <20250217-nova_timer-v1-1-78c5ace2d987@nvidia.com> References: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> In-Reply-To: <20250217-nova_timer-v1-0-78c5ace2d987@nvidia.com> To: Danilo Krummrich , David Airlie , John Hubbard , Ben Skeggs Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alexandre Courbot X-Mailer: b4 0.14.2 X-ClientProxiedBy: TYCP301CA0076.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:7b::10) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|MN2PR12MB4208:EE_ X-MS-Office365-Filtering-Correlation-Id: afccc283-ab71-4a81-ad63-08dd4f5c0dd0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?jg1pVBPS5dL8gBR9vV6Ckp2hY3SDuwa?= =?utf-8?q?9zFIpOFGAE2pMHozEcBU3edZLC9bYrQv34jGuNwfZY0vWbZS1IRoKYcCXX6fUNBGm?= =?utf-8?q?wMcR/LjlAA2qyTNbApAASz3KcsCo2D5BJmckW5slnEI/39ipYLAvPDNUH2eEIfrxK?= =?utf-8?q?F3tr0AxyubRoDnse+oRQp1M4xHN0Gitj5d83p1Ohw2T/4+JhL1yTFuJiDZho7u7hC?= =?utf-8?q?ER4wKzSZRsD5t/OtTT5nxM+L3zXYHdBIavz/u9J/87ZQz/nBJqU7INYDW28IU8U5O?= =?utf-8?q?zdBx1ClOlMUoqb3JC+dIIidfa27XJdOa/cXyc685836NgJrhyB2dZrPB/WMurTQG/?= =?utf-8?q?tKxz4nmoacVD46BUCmwzGpJ3qlMWkvuOlDijKuHHEt4O+gwvAO//ZHpCuBSg20A7S?= =?utf-8?q?eo7gFGBsOaWJBxotIrTD7LDtsIRVWFubBaX793QEUk4GPCp4iv3tstJ72hYUxRXYG?= =?utf-8?q?jEv2HdvutLC4TQMRS8GVgV+WQcAJMJu14x9DwqPBvDPwkfYxOa2gOhS6UHc3iyucl?= =?utf-8?q?E0BqVkiYLWK6v7Qj94xRk8dArYC/yHlD5OaimEk0ZiS6QT8OeOfhjK7SXapcaVbei?= =?utf-8?q?R5KH++6UqleQJRt1TKc7eFcPr0h5eX9U3svtOradBEI54iAnjAZpLIX6WdsEB4E8Q?= =?utf-8?q?YBOkdGY7G3ayor53euS0PCYHai9AYO9Zs6S5IfEw+rwCNpwhW8Hx3HqRMtkOO6TyC?= =?utf-8?q?Saz5TXwzn6dJdT1uHNPidGXsQv3+Wm4g8ZnhuVyB/ILqf2l5eFks57/Ip0mwNbVyU?= =?utf-8?q?vKkIitKQemgEibDqw2wQ3z10H8LuodVBTkM+r4MFDoFjGh/epvIwhghZY5hxf+5BN?= =?utf-8?q?YS70Mzz8WsmsipUVfkLft7UEEWtAO71FPris4KS+Ym0pRIi+ff+gdYa8EdKMYwT12?= =?utf-8?q?Tkowt/uBPYRG7FQ2+Lfy3nLSW8JUgDNt8YRi8Hrl+g+THYy5tWnUS+u5uFtXfI9+O?= =?utf-8?q?7qobDESTYm0E9ZVwqBHUYJtr7000kNY2C4wWdsx5gZaJfMrBAZYIvawYkxSIzJpmi?= =?utf-8?q?MZVjTXDr9MEoXQ6Z1V/wjA417RMZtHsfqqOKqOas7bga2e3BN6vi6wJR5TcIqULNi?= =?utf-8?q?OHH23BuqO5ClYI0XbcOTJl8EfoQAixAqJyjQ3kg8WS3JGhFIo4hRNOUBl4AZjJC4B?= =?utf-8?q?kGTL9Z9G8Cw+7qtnsfWn4/DQp78rELXBwF5Oy0TbVEToFuy9h4AvPjtIBvVPBEF9p?= =?utf-8?q?4EvM5nwHrwkmkbFMtHpczjuDLrZpmxI2ta722Y+NyUDnQ+XcLgo6bqabi6kyDY0Fw?= =?utf-8?q?QoSBdRV9yNpx/9Jo4Oh5MhPXUtfDKYS4pG/Ao0Ter50sZX1lakw+/7hMdchsKDIFP?= =?utf-8?q?2sf1VV6PvsRa?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB3990.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Zc0q47i92E/gDnnxIJ6Ljp8+Vkzr?= =?utf-8?q?FIVvaB8dGKNm4/TD7I/z+fpRv8VsFLT4i1HmOv8s2iZaPtuEhgen1gH/aqR2twEps?= =?utf-8?q?AkrQio/PAy3ztVJ9qXFo700cZUaDODPgoVtFS90c26yFGKnHghaGfokDP0FXFeQen?= =?utf-8?q?KJ3XAvYjRueKLafM1q7cu89psqokS7Cht0+l5Wij0Wplv0i2WYs4Z5Fx/bcLkwtEB?= =?utf-8?q?htRscPC96osyFPhL9ELsh7n00UF9LLZCVi1U7ESN7giNoEPoK0cmrdZyaIQT4sxJj?= =?utf-8?q?wZOP9wQ5kWyFPj7FRKWQ0iMD/U/+okZ+RTwrpDV8WGwhBBw+l3H60kHNoLAsrEWNp?= =?utf-8?q?fys6W5Sp/KIWyBkCpfJYZUvKJXWaNV66ixd9Wvcq9q70mFavo2bPdqyJMdMRH9kkM?= =?utf-8?q?TDzK0mmOkD543ddk+LeNbWPu4FxxqtRda2z8uwM9ptHb96FkyjKj33cHY4BW67B+A?= =?utf-8?q?vOwcNPLxyue4XVBIQ8vB4tYZmKQG2pW1GYsbvsACfkuwyqoBqPy5bqGIgvR7cChKK?= =?utf-8?q?njfjbwfgVu7Hjxa8CNAiWxCKkCVovgGTQWKphGnjRezhpNLCa7Ls7bGjCSTcJ2U97?= =?utf-8?q?A7S5veQ9CdhIlABJvD24UL87oO/Pn4BAqgIaldQSzReIM5w7GfaOwFfrYYorUCbO5?= =?utf-8?q?jeTLn/WFLKbhJ1tOrTGKSt7ZEYO7d/UUz/nNSUNKxhANvTUJKZpyx2HBd8/iyd6Qg?= =?utf-8?q?sFMwqVKlseI/HhH9MUvyETiGnaeWrB8F2jBSSET26hU4FD5x5Z2dWjZdP5CKiaCm/?= =?utf-8?q?zVpLjt6qfJxx+fz0xPPsFPAZH6DjPqsZGRrnQkjW/ym8lrejf/1dzMdirqViFGnmq?= =?utf-8?q?1AJkk60k8h3nE/V2uPiVfTsRO8pWropuEazbAN/HBG9b4dHiYZu1qwdcHbDt6TTgi?= =?utf-8?q?DTqVbaAKxyYwXuW979fSm50iVpJbIIpSUmuhZv+moIAyp3lANg1bZu4x0bLT90QbD?= =?utf-8?q?+uYsHYR0GzHy8ESiWrjXzjh3ORqTfZdnixtjQbI0PtqxwdSI6yLkWa0+dg5k/ANpK?= =?utf-8?q?fveVAbpHAh2f3g/22kvxMqnw0hTXPpMWmcw/Eh4SfZD1O/H5I6OHr8PPfAdKs3L16?= =?utf-8?q?5QeNcNgKcXidrqomadf0VMIFz1SBEZLe0fBRhUROF7nWl8jUYTtstc5bxeA14r08d?= =?utf-8?q?fSS403VpvcYXD+dBuJBea8aHGI4FddGfrASXZbCNjpo5xZiTZwSHSq7Zw1Jy8ciTn?= =?utf-8?q?8qw1m/DGtwMV9u0BM2nSycL2lHSLvndXbrmw1wxE5ec17uDEioPfocMPRiX/82Y6i?= =?utf-8?q?lnFoGlDz8d9iBxpoIuVkoUSSzbC5ZJO/9Y380o+WXmL74hU4JRSbNLLc19mkDNIZ6?= =?utf-8?q?uvcjER26A7Mt5NfbS7JOv8JbOONvSUL4HF5chTJnofqrpL3Thz3QQ6GkljDgIT1K9?= =?utf-8?q?tX8sPR+h0FaMHvjpC6/3n6r8PofYZb6xXptZRMWrLJw7p++6ataNd2vHj6cKCzrAL?= =?utf-8?q?UcNWN4FdErnLtjdz6pjjXMbpWVcXTGyf1U8QJPz7DWoMK27DPGHc7SpGvv6P6BMuK?= =?utf-8?q?XnYMEfQjeNCdQxxoKbDFe4zssRyHuutRbORSiaaYzxKjPsepyT3whTxoJUMg60rxl?= =?utf-8?q?xKV2MYtcSuI?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: afccc283-ab71-4a81-ad63-08dd4f5c0dd0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2025 14:04:54.6271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqfm1WcBo9gcf+0UtFOIXPq3avpG4vTlCEYISPhcOoyu7zAxQkca1alO6bNlss8ij4TYUJna1V4HlqNjZ2eDBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" It is common to build a u64 from its high and low parts obtained from two 32-bit registers. Conversely, it is also common to split a u64 into two u32s to write them into registers. Add an extension trait for u64 that implement these methods in a new `num` module. It is expected that this trait will be extended with other useful operations, and similar extension traits implemented for other types. Signed-off-by: Alexandre Courbot Reviewed-by: Sergio González Collado --- rust/kernel/lib.rs | 1 + rust/kernel/num.rs | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 496ed32b0911a9fdbce5d26738b9cf7ef910b269..8c0c7c20a16aa96e3d3e444be3e03878650ddf77 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -59,6 +59,7 @@ pub mod miscdevice; #[cfg(CONFIG_NET)] pub mod net; +pub mod num; pub mod of; pub mod page; #[cfg(CONFIG_PCI)] diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs new file mode 100644 index 0000000000000000000000000000000000000000..5e714cbda4575b8d74f50660580dc4c5683f8c2b --- /dev/null +++ b/rust/kernel/num.rs @@ -0,0 +1,32 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Numerical and binary utilities for primitive types. + +/// Useful operations for `u64`. +pub trait U64Ext { + /// Build a `u64` by combining its `high` and `low` parts. + /// + /// ``` + /// use kernel::num::U64Ext; + /// assert_eq!(u64::from_u32s(0x01234567, 0x89abcdef), 0x01234567_89abcdef); + /// ``` + fn from_u32s(high: u32, low: u32) -> Self; + + /// Returns the `(high, low)` u32s that constitute `self`. + /// + /// ``` + /// use kernel::num::U64Ext; + /// assert_eq!(u64::into_u32s(0x01234567_89abcdef), (0x1234567, 0x89abcdef)); + /// ``` + fn into_u32s(self) -> (u32, u32); +} + +impl U64Ext for u64 { + fn from_u32s(high: u32, low: u32) -> Self { + ((high as u64) << u32::BITS) | low as u64 + } + + fn into_u32s(self) -> (u32, u32) { + ((self >> u32::BITS) as u32, self as u32) + } +}