From patchwork Tue Feb 18 12:41:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 13979773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1796AC021AA for ; Tue, 18 Feb 2025 12:42:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 821B810E3B2; Tue, 18 Feb 2025 12:42:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="SWwsQ1Nx"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE81910E3B2 for ; Tue, 18 Feb 2025 12:42:10 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B64DA5C55D4; Tue, 18 Feb 2025 12:41:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BED1AC4CEE9; Tue, 18 Feb 2025 12:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739882529; bh=53+Jq1bsLhyjJZLdqY5IT9VqwmYxkNtjI8g1D826Ef4=; h=From:To:Cc:Subject:Date:From; b=SWwsQ1Nxh3mXXGdYakmphpXJbo2sg6eci213YGVqDhaz5f3lwr+BiZBjxw27oOs4O xOpyMCkw4erAHDEh/a6BUTwgGtvqM9zZznnNuW9wUm1+U6EHVXlA1lamPWAKzUKzRH 4HL64AE53ualjtscUe4b5xQHq2I4LGOi+XuC3myGhuClIRkuhkgyNrfNTTfDv4PezN ik+TwkwLr7hQfc81L0vJuaNp+LG0MrbtaN216Pj7zn7DJMRiyUImK3MV782fbsAbM2 hA0ISKfNuiNYYyeil9s9CMCdYzVZAn6ajghqRH6Qgu1Mhw2amWpEd4iZ8QXi7c4Ch0 s3IxcRfG2bHqA== From: Philipp Stanner To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?utf-8?q?Christian_K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Tvrtko Ursulin Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH] drm/sched: Fix preprocessor guard Date: Tue, 18 Feb 2025 13:41:50 +0100 Message-ID: <20250218124149.118002-2-phasta@kernel.org> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When writing the header guard for gpu_scheduler_trace.h, a typo, apparently, occurred. Fix the typo and document the scope of the guard. Fixes: 353da3c520b4 ("drm/amdgpu: add tracepoint for scheduler (v2)") Signed-off-by: Philipp Stanner Reviewed-by: Tvrtko Ursulin --- I just discovered this. But I have little understanding of what is going on in this header in the first place, so I kindly ask for comments on this entire guard line with its logical or || The code hasn't been touched since 2015. So it seems it at least didn't cause bugs. P. --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h index c75302ca3427..f56e77e7f6d0 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h @@ -21,7 +21,7 @@ * */ -#if !defined(_GPU_SCHED_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) +#if !defined(_GPU_SCHED_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ) #define _GPU_SCHED_TRACE_H_ #include @@ -106,7 +106,7 @@ TRACE_EVENT(drm_sched_job_wait_dep, __entry->seqno) ); -#endif +#endif /* _GPU_SCHED_TRACE_H_ */ /* This part must be outside protection */ #undef TRACE_INCLUDE_PATH