From patchwork Thu Feb 20 10:26:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13983674 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50D67C021B1 for ; Thu, 20 Feb 2025 10:26:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACF5910E922; Thu, 20 Feb 2025 10:26:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="L5Z3Aa6M"; dkim-atps=neutral Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5192B10E91D for ; Thu, 20 Feb 2025 10:26:33 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-546237cd3cbso819546e87.0 for ; Thu, 20 Feb 2025 02:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740047191; x=1740651991; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X3V4xBbQpvjplr+11vPrizjbtJxjqV5/lKZ5s7afZXk=; b=L5Z3Aa6MnKj04v+i5SnkwWmGI1mRSSvOE5+IGvCCJjSwnquRCQNg9mV95K5Zdef5ha 7avP6miRryhij0ruCOB/Y9S0mvja0QORcdmgLqdbEXgt9N0RZ/y/HOe2MU/8t7KKyE4Z ASU4xTSGbdRO3nAW/DK30d16hO+WPnSMkAESCxx4Uu5MK9LUZ2YdLyO4z1aUccBX3xaO q3rV1LbJ3hmbNEVji9RTC6B3CLF13SPH0KFe6PKgO+yP2NMOsfhWxphaHvqIQqqFWaVv AhR/Z5bu8suQFwDlRdXWoAZprFQqEuAT5r2EdK+fpbSR1NcpQtdw4TIOnBCFc0a5hWYy h7dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740047192; x=1740651992; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X3V4xBbQpvjplr+11vPrizjbtJxjqV5/lKZ5s7afZXk=; b=csaedw6pG/3PqmBaNXkCOoHe7K4BZuoYLex0ibbIYgAbhSUF9IBQ6TkJbqa4LlGRm6 8XQ9pwP6IxDN18i7UIpBs2Jr6+VRSnUFVnoxjlprt9k+7SWdlAg3mW9gDEzgHnYXnnEB 8DABEahzT3nAyMvsVXwTsofwpBZcChjiRbMNgAS9Kxf2BPTFxGAKO+37RbvYIOeSL3bn 65WpcoC4g1jGCekVplAa84DGaGZb2RFDCSUGlkxYE612/b/kcNTHVg2AVUHZrElkdcse cBpLdSPw5jyT/gqPrBF2DyFevVpBhQOZ4q5rLxKs/pPSgUMhGYwnvlLIHUTlnQis5xtE TuaQ== X-Forwarded-Encrypted: i=1; AJvYcCU9tHCI/ZYT2eootjism7s1ZkCxAy8rXf71WoWEGpa9yhRwN5Kt2z989yAcQgQ6OXh32bSzUF45/nI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwwJ8Rc5nzn4LeRhF4je6zeffR/DLMsRA1xFHoCRWDUsCsxCFyf EkcaQSruWnaZXfyGhNpv2sVMwCqOLG4W2719FBUGkSvDQJXjMx4/1KbF+Mg7hG89O+rm5IQYjZX K X-Gm-Gg: ASbGncuJPiZm6HqVkNC6gMGCwuHgiXHs23z1TPVKQNBlXCTTG8HH9++BK+o39eKix6c TkaoPOSuxthilaTK99Xu+z5K6pFk9gs7+Jz0CWH+ZHdW/X+hz34frDBMxi6VF0B3L/z+nl3rZkn RrpJysgeljRhHkeBTYpbKbfdB6himA6mGByTQPJq/7hBtjwCvFblS3h+/2wEDsVEEQHWOx/Edil 84li8BYKCYG5v88ZOCbSSjqxD7HfTTiswLizdq5BFDGd9aKf8g+dgt69ykMooxbX3tMRss9bhTl HHLp9jizr1xki4u/zkpTUCc= X-Google-Smtp-Source: AGHT+IFT7l/AtVtBLArk2SRlJ/wJq5MyR0YALvIDoLeckr+vIWmad/Qo311RAVJkfTcP2k498cUn/A== X-Received: by 2002:a05:6512:eaa:b0:545:c9d:ef26 with SMTP id 2adb3069b0e04-5452fea5da8mr7575910e87.46.1740047191589; Thu, 20 Feb 2025 02:26:31 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-545e939224esm1588052e87.135.2025.02.20.02.26.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 02:26:31 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 20 Feb 2025 12:26:22 +0200 Subject: [PATCH 5/7] drm/msm/dpu: don't select single flush for active CTL blocks MIME-Version: 1.0 Message-Id: <20250220-dpu-active-ctl-v1-5-71ca67a564f8@linaro.org> References: <20250220-dpu-active-ctl-v1-0-71ca67a564f8@linaro.org> In-Reply-To: <20250220-dpu-active-ctl-v1-0-71ca67a564f8@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1072; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Mj6W/g1cQTXrPDSCV2G/UAnCYQZDcnBUJoxZDb1VnZ4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBntwNLSoDCJhBaYmL2ldFx0C1L91FbiV3nkagNu zV9tG1YFlWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ7cDSwAKCRCLPIo+Aiko 1Xl+CACrEnvEy3oMgM9VlWjdwvKg0hXcZYrjUorlyeRUYERUk9dlZKLpH1zwax5tK0rUBc6Eq47 A3Jpti5ik0g9bLxSisjpAwlNEgK+js56CDJ/++RgzCxWtZNligajW7lTnYDiWekbR1DngK1HBLU RZtrlTc9BE62ycVDxN9iwpfzyZKNi7Odk6UAgnA1RPb9l/WBnh5bAqytMKywl70PCuDC7N6XkvH kKQhlVaF5U+ZYU8lYwds1aI8QQlXAQ6JtpeoubML+TUyeONzeyyJICJcLrS6Dqhec64HUfPnuGi TPufr0KlKKM4eweQwpOnN2F7QE5k4Qt3bfsUPj5sfEzj9JkU X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In case of ACTIVE CTLs, a single CTL is being used for flushing all INTF blocks. Don't skip programming the CTL on those targets. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index 232055473ba55998b79dd2e8c752c129bbffbff4..8a618841e3ea89acfe4a42d48319a6c54a1b3495 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -374,7 +374,8 @@ static void dpu_encoder_phys_vid_underrun_irq(void *arg) static bool dpu_encoder_phys_vid_needs_single_flush( struct dpu_encoder_phys *phys_enc) { - return phys_enc->split_role != ENC_ROLE_SOLO; + return !(phys_enc->hw_ctl->caps->features & BIT(DPU_CTL_ACTIVE_CFG)) && + phys_enc->split_role != ENC_ROLE_SOLO; } static void dpu_encoder_phys_vid_atomic_mode_set(