diff mbox series

[v2] drm/imagination: only init job done fences once

Message ID 20250226-init-done-fences-once-v2-1-c1b2f556b329@imgtec.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm/imagination: only init job done fences once | expand

Commit Message

Brendan King via B4 Relay Feb. 26, 2025, 3:43 p.m. UTC 
From: Brendan King <Brendan.King@imgtec.com>

Ensure job done fences are only initialised once.

This fixes a memory manager not clean warning from drm_mm_takedown
on module unload.

Cc: stable@vger.kernel.org
Fixes: eaf01ee5ba28 ("drm/imagination: Implement job submission and scheduling")
Signed-off-by: Brendan King <brendan.king@imgtec.com>
---
Changes in v2:
- Added 'Cc:' and 'Fixes:' tags
- Link to v1: https://lore.kernel.org/r/20250203-init-done-fences-once-v1-1-a2d62406564b@imgtec.com
---
 drivers/gpu/drm/imagination/pvr_queue.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


---
base-commit: 3ab334814dc7dff39075e055e12847d51878916e
change-id: 20250131-init-done-fences-once-c55c5d0f4d8c

Best regards,

Comments

Matt Coster March 3, 2025, 12:14 p.m. UTC | #1 
On Wed, 26 Feb 2025 15:43:54 +0000, Brendan King wrote:
> Ensure job done fences are only initialised once.
> 
> This fixes a memory manager not clean warning from drm_mm_takedown
> on module unload.
> 
> 

Applied, thanks!

[1/1] drm/imagination: only init job done fences once
      commit: 68c3de7f707e8a70e0a6d8087cf0fe4a3d5dbfb0

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
index c4f08432882b12f5cdfeb7fc991fd941f0946676..9a67e646f1eae709859f664c796e1940f0b45300 100644
--- a/drivers/gpu/drm/imagination/pvr_queue.c
+++ b/drivers/gpu/drm/imagination/pvr_queue.c
@@ -304,8 +304,9 @@  pvr_queue_cccb_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
 static void
 pvr_queue_job_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
 {
-	pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
-			     &queue->job_fence_ctx);
+	if (!fence->ops)
+		pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
+				     &queue->job_fence_ctx);
 }
 
 /**