| Message ID | 20250303151840.3669656-1-ashley.smith@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panthor: Update CS_STATUS_ defines to correct values | expand |
On Mon, 3 Mar 2025 15:18:37 +0000 Ashley Smith <ashley.smith@collabora.com> wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented at https://arm.pages.collabora.com/mali-docs/g610-odin-csf/register/CS_KERNEL_OUTPUT_BLOCK.htm#rp_CS_KERNEL_OUTPUT_BLOCK/CS_STATUS_BLOCKED_REASON > > This change updates the defines to the correct values. > > Signed-off-by: Ashley Smith <ashley.smith@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/panthor/panthor_fw.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h > index 22448abde992..4d3c8b585dcb 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.h > +++ b/drivers/gpu/drm/panthor/panthor_fw.h > @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface { > #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1 > #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2 > #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3 > -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5 > -#define CS_STATUS_BLOCKED_REASON_RES 6 > -#define CS_STATUS_BLOCKED_REASON_FLUSH 7 > +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4 > +#define CS_STATUS_BLOCKED_REASON_RES 5 > +#define CS_STATUS_BLOCKED_REASON_FLUSH 6 > #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0) > u32 status_blocked_reason; > u32 status_wait_sync_value_hi; > > base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
On 03/03/2025 15:18, Ashley Smith wrote: > Values for SC_STATUS_BLOCKED_REASON_ are documented at https://arm.pages.collabora.com/mali-docs/g610-odin-csf/register/CS_KERNEL_OUTPUT_BLOCK.htm#rp_CS_KERNEL_OUTPUT_BLOCK/CS_STATUS_BLOCKED_REASON Please don't reference a URL which isn't accessible to 'normal' people ;) Something like... as documented in the G610 "Odin" GPU specification (CS_STATUS_BLOCKED_REASON register) ...would hopefully be enough to find the relevant documentation for those of us that have it. > > This change updates the defines to the correct values. > > Signed-off-by: Ashley Smith <ashley.smith@collabora.com> > --- > drivers/gpu/drm/panthor/panthor_fw.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h > index 22448abde992..4d3c8b585dcb 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.h > +++ b/drivers/gpu/drm/panthor/panthor_fw.h > @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface { > #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1 > #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2 > #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3 > -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5 > -#define CS_STATUS_BLOCKED_REASON_RES 6 > -#define CS_STATUS_BLOCKED_REASON_FLUSH 7 > +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4 > +#define CS_STATUS_BLOCKED_REASON_RES 5 NIT: The actual name is RESOURCE not RES. So if we're updating to match the spec we could rename it (it isn't currently used by the driver). The actual updated values are correct, so with the above fixed: Reviewed-by: Steven Price <steven.price@arm.com> You might also want: Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") Thanks, Steve > +#define CS_STATUS_BLOCKED_REASON_FLUSH 6 > #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0) > u32 status_blocked_reason; > u32 status_wait_sync_value_hi; > > base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
> Please don't reference a URL which isn't accessible to 'normal' people > ;) Something like... > > as documented in the G610 "Odin" GPU specification > (CS_STATUS_BLOCKED_REASON register) > > ...would hopefully be enough to find the relevant documentation for > those of us that have it. You are correct, apologies for that! I will send a v2 with the renamed _RES as you correctly mentioned it isn't used yet. > You might also want: > > Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") I will add this also. Thanks, Ash
diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h index 22448abde992..4d3c8b585dcb 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.h +++ b/drivers/gpu/drm/panthor/panthor_fw.h @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface { #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1 #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2 #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3 -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5 -#define CS_STATUS_BLOCKED_REASON_RES 6 -#define CS_STATUS_BLOCKED_REASON_FLUSH 7 +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4 +#define CS_STATUS_BLOCKED_REASON_RES 5 +#define CS_STATUS_BLOCKED_REASON_FLUSH 6 #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0) u32 status_blocked_reason; u32 status_wait_sync_value_hi;
Values for SC_STATUS_BLOCKED_REASON_ are documented at https://arm.pages.collabora.com/mali-docs/g610-odin-csf/register/CS_KERNEL_OUTPUT_BLOCK.htm#rp_CS_KERNEL_OUTPUT_BLOCK/CS_STATUS_BLOCKED_REASON This change updates the defines to the correct values. Signed-off-by: Ashley Smith <ashley.smith@collabora.com> --- drivers/gpu/drm/panthor/panthor_fw.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de