| Message ID | 20250306155155.212599-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] drm/gma500: Remove unused mrst_clock_funcs | expand |
On Thu, Mar 6, 2025 at 4:52 PM <linux@treblig.org> wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > The mrst_clock_funcs const was added in 2013 by > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > and commented as 'Not used yet'. > > It's not been used since, so remove it. > The helper functions it points to are still used elsewhere. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Applied to drm-misc-next Thanks > --- > v2 > commit message fixed to use correct struct name, and add > note about the functions used still being used. > > drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index de8ccfe9890f..ea9b41af0867 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { > .prepare = gma_crtc_prepare, > .commit = gma_crtc_commit, > }; > - > -/* Not used yet */ > -const struct gma_clock_funcs mrst_clock_funcs = { > - .clock = mrst_lvds_clock, > - .limit = mrst_limit, > - .pll_is_valid = gma_pll_is_valid, > -}; > -- > 2.48.1 >
* Patrik Jakobsson (patrik.r.jakobsson@gmail.com) wrote: > On Thu, Mar 6, 2025 at 4:52 PM <linux@treblig.org> wrote: > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > The mrst_clock_funcs const was added in 2013 by > > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > > and commented as 'Not used yet'. > > > > It's not been used since, so remove it. > > The helper functions it points to are still used elsewhere. > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > Applied to drm-misc-next Thanks! Dave > Thanks > > > > --- > > v2 > > commit message fixed to use correct struct name, and add > > note about the functions used still being used. > > > > drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > > index de8ccfe9890f..ea9b41af0867 100644 > > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > > @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { > > .prepare = gma_crtc_prepare, > > .commit = gma_crtc_commit, > > }; > > - > > -/* Not used yet */ > > -const struct gma_clock_funcs mrst_clock_funcs = { > > - .clock = mrst_lvds_clock, > > - .limit = mrst_limit, > > - .pll_is_valid = gma_pll_is_valid, > > -}; > > -- > > 2.48.1 > >
diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c index de8ccfe9890f..ea9b41af0867 100644 --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { .prepare = gma_crtc_prepare, .commit = gma_crtc_commit, }; - -/* Not used yet */ -const struct gma_clock_funcs mrst_clock_funcs = { - .clock = mrst_lvds_clock, - .limit = mrst_limit, - .pll_is_valid = gma_pll_is_valid, -};