From patchwork Wed Mar 12 07:24:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uma Shankar X-Patchwork-Id: 14012984 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5966FC28B2E for ; Wed, 12 Mar 2025 07:13:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9A5510E723; Wed, 12 Mar 2025 07:13:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MMxJCJLU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B8310E71D; Wed, 12 Mar 2025 07:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741763621; x=1773299621; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4416AmFyniVr9hVMluf5/wZ4m+9QPlpZS3fOZdkn/do=; b=MMxJCJLUoSIOu3EEkSGwPRwbrDG5pwJKxjfF2Y8YpZsEiE/Ecoc7S3SH HC1ltAbKXr5AoEswBsK07goa1Wi3zVdyrQ4zjJLW12ev9o0a15rKakFgZ 2l0hnuCGUs0zEVn3QA/9ulIqvopqJUbVYJ/ySr8azloTuT+afPtYzlDON PXDg0A66pdUED2g8V7x/SpehO8l8aWx2f9AiYMtAb+qsKSUqUbefiLUx9 10bqxlrbMb5Hk9WXZ9gDEbitsAsWx9Hov++0BbAkCkFxi8uQeLgpmLyyy 2q0nWhTJ1o8L49PtTIJlLhGT6bRlpG2x2CD6DYlla+HxqGBgxNh7HmIcY Q==; X-CSE-ConnectionGUID: QE/I7MvcTEWLBnV8pw83sw== X-CSE-MsgGUID: VpuJJGSeR9ap60mYnIboIQ== X-IronPort-AV: E=McAfee;i="6700,10204,11370"; a="65288948" X-IronPort-AV: E=Sophos;i="6.14,241,1736841600"; d="scan'208";a="65288948" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2025 00:13:41 -0700 X-CSE-ConnectionGUID: CzHWtujcTIaA1RuCxlww8g== X-CSE-MsgGUID: ekB7RsOhQyO3U7sgzcUx1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,241,1736841600"; d="scan'208";a="120368560" Received: from cfl-desktop.iind.intel.com ([10.190.239.20]) by fmviesa006.fm.intel.com with ESMTP; 12 Mar 2025 00:13:37 -0700 From: Uma Shankar To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: ville.syrjala@linux.intel.com, harry.wentland@amd.com, pekka.paalanen@haloniitty.fi, sebastian.wick@redhat.com, jadahl@redhat.com, mwen@igalia.com, contact@emersion.fr, naveen1.kumar@intel.com, Chaitanya Kumar Borah , Uma Shankar Subject: [v4 22/23] drm/i915/color: Enable Plane Color Pipelines Date: Wed, 12 Mar 2025 12:54:24 +0530 Message-ID: <20250312072425.3099205-23-uma.shankar@intel.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20250312072425.3099205-1-uma.shankar@intel.com> References: <20250312072425.3099205-1-uma.shankar@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Chaitanya Kumar Borah Expose color pipeline and add ability to program it. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c index 70e550539bb2..9c2a4a2544e7 100644 --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c @@ -12,6 +12,7 @@ #include "i915_reg.h" #include "intel_atomic_plane.h" #include "intel_bo.h" +#include "intel_color.h" #include "intel_de.h" #include "intel_display_irq.h" #include "intel_display_types.h" @@ -1548,6 +1549,8 @@ icl_plane_update_noarm(struct intel_dsb *dsb, plane_color_ctl = plane_state->color_ctl | glk_plane_color_ctl_crtc(crtc_state); + intel_program_pipeline(&plane_state->uapi, &plane_color_ctl); + /* The scaler will handle the output position */ if (plane_state->scaler_id >= 0) { crtc_x = 0; @@ -2952,6 +2955,8 @@ skl_universal_plane_create(struct intel_display *display, DRM_COLOR_YCBCR_BT709, DRM_COLOR_YCBCR_LIMITED_RANGE); + intel_plane_color_init(&plane->base); + drm_plane_create_alpha_property(&plane->base); drm_plane_create_blend_mode_property(&plane->base, BIT(DRM_MODE_BLEND_PIXEL_NONE) |