| Message ID | 20250313161424.10688-1-qasdev00@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk() | expand |
Am 13.03.25 um 17:14 schrieb Qasim Ijaz: > In the ttm_bo_unreserve_bulk() test function, resv is allocated using > kunit_kzalloc(), but the subsequent assertion mistakenly verifies the > ttm_dev pointer instead of the resv pointer. > > Fix the assertion to properly verify the resv pointer. > > Signed-off-by: Qasim Ijaz <qasdev00@gmail.com> Reviewed and pushed. Thanks, Christian. > --- > drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > index f8f20d2f6174..e08e5a138420 100644 > --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c > @@ -340,7 +340,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test) > KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > > resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); > - KUNIT_ASSERT_NOT_NULL(test, ttm_dev); > + KUNIT_ASSERT_NOT_NULL(test, resv); > > err = ttm_device_kunit_init(priv, ttm_dev, false, false); > KUNIT_ASSERT_EQ(test, err, 0);
diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c index f8f20d2f6174..e08e5a138420 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c @@ -340,7 +340,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test) KUNIT_ASSERT_NOT_NULL(test, ttm_dev); resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL); - KUNIT_ASSERT_NOT_NULL(test, ttm_dev); + KUNIT_ASSERT_NOT_NULL(test, resv); err = ttm_device_kunit_init(priv, ttm_dev, false, false); KUNIT_ASSERT_EQ(test, err, 0);
In the ttm_bo_unreserve_bulk() test function, resv is allocated using kunit_kzalloc(), but the subsequent assertion mistakenly verifies the ttm_dev pointer instead of the resv pointer. Fix the assertion to properly verify the resv pointer. Signed-off-by: Qasim Ijaz <qasdev00@gmail.com> --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)