| Message ID | 20250323114103.1960511-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,-next] drm/xe: Fix unmet direct dependencies warning | expand |
On Sun, Mar 23, 2025 at 07:41:03PM +0800, Yue Haibing wrote: >WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS > Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] > Selected by [m]: > - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y] > >DRM_XE_DISPLAY requires FB_IOMEM_HELPERS, but the dependency FB_CORE is >missing, selecting FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION is set as >other drm drivers. > >Fixes: 44e694958b95 ("drm/xe/display: Implement display support") >Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> I will apply it soon to drm-xe-next. thanks Lucas De Marchi >--- >v2: select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION instead of select FB_CORE >--- > drivers/gpu/drm/xe/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig >index 7d7995196702..5c2f459a2925 100644 >--- a/drivers/gpu/drm/xe/Kconfig >+++ b/drivers/gpu/drm/xe/Kconfig >@@ -53,7 +53,7 @@ config DRM_XE > config DRM_XE_DISPLAY > bool "Enable display support" > depends on DRM_XE && DRM_XE=m && HAS_IOPORT >- select FB_IOMEM_HELPERS >+ select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION > select I2C > select I2C_ALGOBIT > default y >-- >2.34.1 >
diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index 7d7995196702..5c2f459a2925 100644 --- a/drivers/gpu/drm/xe/Kconfig +++ b/drivers/gpu/drm/xe/Kconfig @@ -53,7 +53,7 @@ config DRM_XE config DRM_XE_DISPLAY bool "Enable display support" depends on DRM_XE && DRM_XE=m && HAS_IOPORT - select FB_IOMEM_HELPERS + select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION select I2C select I2C_ALGOBIT default y
WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]: - DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y] DRM_XE_DISPLAY requires FB_IOMEM_HELPERS, but the dependency FB_CORE is missing, selecting FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION is set as other drm drivers. Fixes: 44e694958b95 ("drm/xe/display: Implement display support") Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- v2: select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION instead of select FB_CORE --- drivers/gpu/drm/xe/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)