diff mbox series

[v3,1/5] drm/panthor: Fix GPU_COHERENCY_ACE[_LITE] definitions

Message ID 20250404080933.2912674-2-boris.brezillon@collabora.com (mailing list archive)
State New
Headers show
Series drm/panthor: Misc fixes | expand

Commit Message

Boris Brezillon April 4, 2025, 8:09 a.m. UTC
GPU_COHERENCY_ACE and GPU_COHERENCY_ACE_LITE definitions have been
swapped.

Changes in v2:
- New patch

Changes in v3:
- Add Steve's R-b

Reported-by: Liviu Dudau <liviu.dudau@arm.com>
Fixes: 546b366600ef ("drm/panthor: Add GPU register definitions")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
---
 drivers/gpu/drm/panthor/panthor_regs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Liviu Dudau April 4, 2025, 1:15 p.m. UTC | #1
On Fri, Apr 04, 2025 at 10:09:29AM +0200, Boris Brezillon wrote:
> GPU_COHERENCY_ACE and GPU_COHERENCY_ACE_LITE definitions have been
> swapped.
> 
> Changes in v2:
> - New patch
> 
> Changes in v3:
> - Add Steve's R-b
> 
> Reported-by: Liviu Dudau <liviu.dudau@arm.com>
> Fixes: 546b366600ef ("drm/panthor: Add GPU register definitions")
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Steven Price <steven.price@arm.com>

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/panthor/panthor_regs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h
> index b7b3b3add166..a7a323dc5cf9 100644
> --- a/drivers/gpu/drm/panthor/panthor_regs.h
> +++ b/drivers/gpu/drm/panthor/panthor_regs.h
> @@ -133,8 +133,8 @@
>  #define GPU_COHERENCY_PROT_BIT(name)			BIT(GPU_COHERENCY_  ## name)
>  
>  #define GPU_COHERENCY_PROTOCOL				0x304
> -#define   GPU_COHERENCY_ACE				0
> -#define   GPU_COHERENCY_ACE_LITE			1
> +#define   GPU_COHERENCY_ACE_LITE			0
> +#define   GPU_COHERENCY_ACE				1
>  #define   GPU_COHERENCY_NONE				31
>  
>  #define MCU_CONTROL					0x700
> -- 
> 2.49.0
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panthor/panthor_regs.h b/drivers/gpu/drm/panthor/panthor_regs.h
index b7b3b3add166..a7a323dc5cf9 100644
--- a/drivers/gpu/drm/panthor/panthor_regs.h
+++ b/drivers/gpu/drm/panthor/panthor_regs.h
@@ -133,8 +133,8 @@ 
 #define GPU_COHERENCY_PROT_BIT(name)			BIT(GPU_COHERENCY_  ## name)
 
 #define GPU_COHERENCY_PROTOCOL				0x304
-#define   GPU_COHERENCY_ACE				0
-#define   GPU_COHERENCY_ACE_LITE			1
+#define   GPU_COHERENCY_ACE_LITE			0
+#define   GPU_COHERENCY_ACE				1
 #define   GPU_COHERENCY_NONE				31
 
 #define MCU_CONTROL					0x700