From patchwork Sat Apr 5 02:45:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sunliming X-Patchwork-Id: 14039074 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49276C36010 for ; Sat, 5 Apr 2025 02:53:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF8D110E07C; Sat, 5 Apr 2025 02:53:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="oKdFSYqe"; dkim-atps=neutral X-Greylist: delayed 421 seconds by postgrey-1.36 at gabe; Sat, 05 Apr 2025 02:53:31 UTC Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A34910E07C for ; Sat, 5 Apr 2025 02:53:31 +0000 (UTC) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743821177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=EP478WzMsSCtRI5Mu7jauIRslH9HlpNNETR+bFH5QtM=; b=oKdFSYqeE317Rli9vCrvCassxByQPZTBufb5vxPkw7IwqVlQ05Q52HOQWdQAmYd3qegXSW HnGfQzfkoHx4nCX1GVq4lkaKHYdxdrhvzGas7TR2y/oN8a2p73BgGZqKLClpYxA034+CdI wOF94oq1+mUJAMIloGkH+YM/9wplvkE= From: sunliming@linux.dev To: mripard@kernel.org, dave.stevenson@raspberrypi.com, mcanal@igalia.com, kernel-list@raspberrypi.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sunliming , kernel test robot , Dan Carpenter Subject: [PATCH] drm/vc4: fix uninitialized smatch warnings Date: Sat, 5 Apr 2025 10:45:03 +0800 Message-Id: <20250405024503.694981-1-sunliming@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: sunliming Fix below smatch warnings: drivers/gpu/drm/vc4/vc4_gem.c:604 vc4_lock_bo_reservations() error: uninitialized symbol 'ret'. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202504021500.3AM1hKKS-lkp@intel.com/ Signed-off-by: sunliming --- drivers/gpu/drm/vc4/vc4_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c index 8125f87edc60..04ea1696fc5d 100644 --- a/drivers/gpu/drm/vc4/vc4_gem.c +++ b/drivers/gpu/drm/vc4/vc4_gem.c @@ -582,7 +582,7 @@ static int vc4_lock_bo_reservations(struct vc4_exec_info *exec, struct drm_exec *exec_ctx) { - int ret; + int ret = 0; /* Reserve space for our shared (read-only) fence references, * before we commit the CL to the hardware.