| Message ID | 20250407-tianma-p0700wxf1mbaa-v2-2-ede8c5a3f538@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: simple: add Tianma P0700WXF1MBAA and improve Tianma TM070JDHG34-00 | expand |
On Mon, Apr 07, 2025 at 06:34:00PM +0200, Luca Ceresoli wrote: > Add power on/off delays for the Tianma TM070JDHG34-00. > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 6 ++++++ > 1 file changed, 6 insertions(+) Fixes: bf6daaa281f7 ("drm/panel: simple: Add Tianma TM070JDHG34-00 panel support") > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index df718c4a86cb7dc0cd126e807d33306e5a21d8a0..3496ed3e62056938ccc0ed2389ea46eed8d17ea2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4452,6 +4452,12 @@ static const struct panel_desc tianma_tm070jdhg34_00 = { > .width = 150, /* 149.76 */ > .height = 94, /* 93.60 */ > }, > + .delay = { > + .prepare = 18, /* Tr + Tp1 */ I think this should be 15, Tr is handled by the regulator, so no need to handled it in the panel driver. > + .enable = 150, /* Tp2 */ > + .disable = 150, /* Tp4 */ > + .unprepare = 120, /* Tp3 */ > + }, > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > -- > 2.49.0 >
Hi Dmitry, Thanks for reviewing. On Tue, 8 Apr 2025 15:52:19 +0300 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > On Mon, Apr 07, 2025 at 06:34:00PM +0200, Luca Ceresoli wrote: > > Add power on/off delays for the Tianma TM070JDHG34-00. > > > > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Fixes: bf6daaa281f7 ("drm/panel: simple: Add Tianma TM070JDHG34-00 panel support") > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index df718c4a86cb7dc0cd126e807d33306e5a21d8a0..3496ed3e62056938ccc0ed2389ea46eed8d17ea2 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -4452,6 +4452,12 @@ static const struct panel_desc tianma_tm070jdhg34_00 = { > > .width = 150, /* 149.76 */ > > .height = 94, /* 93.60 */ > > }, > > + .delay = { > > + .prepare = 18, /* Tr + Tp1 */ > > I think this should be 15, Tr is handled by the regulator, so no need to > handled it in the panel driver. Hm, I think you are right. I'm applying both changes but I'll wait a few days before sending v3, in case of further feedback. Luca
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index df718c4a86cb7dc0cd126e807d33306e5a21d8a0..3496ed3e62056938ccc0ed2389ea46eed8d17ea2 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -4452,6 +4452,12 @@ static const struct panel_desc tianma_tm070jdhg34_00 = { .width = 150, /* 149.76 */ .height = 94, /* 93.60 */ }, + .delay = { + .prepare = 18, /* Tr + Tp1 */ + .enable = 150, /* Tp2 */ + .disable = 150, /* Tp4 */ + .unprepare = 120, /* Tp3 */ + }, .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, .connector_type = DRM_MODE_CONNECTOR_LVDS, };
Add power on/off delays for the Tianma TM070JDHG34-00. Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com> --- drivers/gpu/drm/panel/panel-simple.c | 6 ++++++ 1 file changed, 6 insertions(+)