| Message ID | 20250409061543.311184-2-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/ci: Add devicetree validation and KUnit tests | expand |
On Wed, 9 Apr 2025 11:45:38 +0530, Vignesh Raman wrote: > Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, > exit with a non-zero error code while configuring them as warning in > the GitLab CI pipeline. > > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > > [ ... ] Reviewed-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote: > Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, > exit with a non-zero error code while configuring them as warning in > the GitLab CI pipeline. > > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > --- > > v2: > - Use LLVM to build. Why? > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Hi Dmitry, On 11/04/25 01:02, Dmitry Baryshkov wrote: > On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote: >> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, >> exit with a non-zero error code while configuring them as warning in >> the GitLab CI pipeline. >> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> >> --- >> >> v2: >> - Use LLVM to build. > > Why? We are using LLVM/Clang instead of GCC to avoid architecture-specific toolchain for cross compiling. This is done to make the script generic and run only kunit tests. I will update this section. > >> > > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > Thanks. Regards, Vignesh
On Fri, 11 Apr 2025 at 11:32, Vignesh Raman <vignesh.raman@collabora.com> wrote: > > Hi Dmitry, > > On 11/04/25 01:02, Dmitry Baryshkov wrote: > > On Wed, Apr 09, 2025 at 11:45:38AM +0530, Vignesh Raman wrote: > >> Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, > >> exit with a non-zero error code while configuring them as warning in > >> the GitLab CI pipeline. > >> > >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > >> --- > >> > >> v2: > >> - Use LLVM to build. > > > > Why? > > We are using LLVM/Clang instead of GCC to avoid architecture-specific > toolchain for cross compiling. This is done to make the script generic > and run only kunit tests. I will update this section. Ack
diff --git a/drivers/gpu/drm/ci/check-devicetrees.yml b/drivers/gpu/drm/ci/check-devicetrees.yml new file mode 100644 index 000000000000..bc96061abe5b --- /dev/null +++ b/drivers/gpu/drm/ci/check-devicetrees.yml @@ -0,0 +1,43 @@ +.dt-check-base: + timeout: "30m" + variables: + FF_USE_NEW_BASH_EVAL_STRATEGY: 'true' + SCHEMA: "display" + before_script: + - apt-get update -qq + - apt-get install -y --no-install-recommends clang lld llvm python3-pip yamllint + - pip3 install dtschema + script: + - drivers/gpu/drm/ci/${SCRIPT_NAME} + artifacts: + when: on_failure + paths: + - ${ARTIFACT_FILE} + allow_failure: + exit_codes: + - 102 + +dtbs-check:arm32: + extends: + - .build:arm32 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dtbs-check:arm64: + extends: + - .build:arm64 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dt-binding-check: + extends: + - .build + - .use-debian/x86_64_build + - .dt-check-base + variables: + SCRIPT_NAME: "dt-binding-check.sh" + ARTIFACT_FILE: "dt-binding-check.log" diff --git a/drivers/gpu/drm/ci/dt-binding-check.sh b/drivers/gpu/drm/ci/dt-binding-check.sh new file mode 100755 index 000000000000..5e9a439c48a4 --- /dev/null +++ b/drivers/gpu/drm/ci/dt-binding-check.sh @@ -0,0 +1,16 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +if ! make -j"${FDO_CI_CONCURRENT:-4}" dt_binding_check \ + DT_SCHEMA_FILES="${SCHEMA:-}" 2>dt-binding-check.log; then + echo "ERROR: 'make dt_binding_check' failed. Please check dt-binding-check.log for details." + exit 1 +fi + +if [[ -s dt-binding-check.log ]]; then + echo "WARNING: dt_binding_check reported warnings. Please check dt-binding-check.log" \ + "for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/dtbs-check.sh b/drivers/gpu/drm/ci/dtbs-check.sh new file mode 100755 index 000000000000..91212f19fb98 --- /dev/null +++ b/drivers/gpu/drm/ci/dtbs-check.sh @@ -0,0 +1,19 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +: "${KERNEL_ARCH:?ERROR: KERNEL_ARCH must be set}" + +make LLVM=1 ARCH="${KERNEL_ARCH}" defconfig + +if ! make -j"${FDO_CI_CONCURRENT:-4}" ARCH="${KERNEL_ARCH}" LLVM=1 dtbs_check \ + DT_SCHEMA_FILES="${SCHEMA:-}" 2>dtbs-check.log; then + echo "ERROR: 'make dtbs_check' failed. Please check dtbs-check.log for details." + exit 1 +fi + +if [[ -s dtbs-check.log ]]; then + echo "WARNING: dtbs_check reported warnings. Please check dtbs-check.log for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml index 65adcd97e06b..9e61b49e9960 100644 --- a/drivers/gpu/drm/ci/gitlab-ci.yml +++ b/drivers/gpu/drm/ci/gitlab-ci.yml @@ -108,6 +108,7 @@ include: - drivers/gpu/drm/ci/static-checks.yml - drivers/gpu/drm/ci/build.yml - drivers/gpu/drm/ci/test.yml + - drivers/gpu/drm/ci/check-devicetrees.yml - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'
Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, exit with a non-zero error code while configuring them as warning in the GitLab CI pipeline. Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> --- v2: - Use LLVM to build. --- drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++ drivers/gpu/drm/ci/dt-binding-check.sh | 16 +++++++++ drivers/gpu/drm/ci/dtbs-check.sh | 19 +++++++++++ drivers/gpu/drm/ci/gitlab-ci.yml | 1 + 4 files changed, 79 insertions(+) create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh