From patchwork Wed Apr 9 06:15:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vignesh Raman X-Patchwork-Id: 14044105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 437B2C36002 for ; Wed, 9 Apr 2025 06:16:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8099010E22B; Wed, 9 Apr 2025 06:16:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="dcen1gNf"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E11F10E303 for ; Wed, 9 Apr 2025 06:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744179379; bh=Q0+RWqDbidHJOmaI/ZLEyzMSqLrglHu+NjLRyV8KpXw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dcen1gNfbHEmpyA+3xL+kTAoozgoPvr8qosAGWRKs+Hj6F2yNhHAKXPxH3RNeXfPC Y2GTMlK1ryLTHncoM8aJZRn6aR2Tj7fThvsrwwyGw+8pmyNswo7i4RTDBQJIQwM6XR 1v6qC9ZUCV8hbaMDNsELMBKw2QZqxcz/Grt3Ym0wkuvm7yA1fv/7Vva7YRm7vq/vgR sCi3ISRtzbwti9+xuYbGiWiZUhxH94aDcqbFCADKg52QBHA0qJCt3DP9+n72nQB6vt Tn7OM8H8Y01Ktv3uPGoDL2x9FLIMVXafZ1vJDEMgbi23TNfcKlt+oaIGrnvn2UmMVs fKJocfVcc1oyg== Received: from debian.. (unknown [171.76.83.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: vignesh) by bali.collaboradmins.com (Postfix) with ESMTPSA id F114E17E0FC1; Wed, 9 Apr 2025 08:16:15 +0200 (CEST) From: Vignesh Raman To: dri-devel@lists.freedesktop.org Cc: daniels@collabora.com, daniel@fooishbar.org, helen.fornazier@gmail.com, airlied@gmail.com, simona.vetter@ffwll.ch, robdclark@gmail.com, guilherme.gallo@collabora.com, sergi.blanch.torne@collabora.com, valentine.burley@collabora.com, lumag@kernel.org, quic_abhinavk@quicinc.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees Date: Wed, 9 Apr 2025 11:45:38 +0530 Message-ID: <20250409061543.311184-2-vignesh.raman@collabora.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250409061543.311184-1-vignesh.raman@collabora.com> References: <20250409061543.311184-1-vignesh.raman@collabora.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, exit with a non-zero error code while configuring them as warning in the GitLab CI pipeline. Signed-off-by: Vignesh Raman Reviewed-by: Maxime Ripard Acked-by: Dmitry Baryshkov --- v2: - Use LLVM to build. --- drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++ drivers/gpu/drm/ci/dt-binding-check.sh | 16 +++++++++ drivers/gpu/drm/ci/dtbs-check.sh | 19 +++++++++++ drivers/gpu/drm/ci/gitlab-ci.yml | 1 + 4 files changed, 79 insertions(+) create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh diff --git a/drivers/gpu/drm/ci/check-devicetrees.yml b/drivers/gpu/drm/ci/check-devicetrees.yml new file mode 100644 index 000000000000..bc96061abe5b --- /dev/null +++ b/drivers/gpu/drm/ci/check-devicetrees.yml @@ -0,0 +1,43 @@ +.dt-check-base: + timeout: "30m" + variables: + FF_USE_NEW_BASH_EVAL_STRATEGY: 'true' + SCHEMA: "display" + before_script: + - apt-get update -qq + - apt-get install -y --no-install-recommends clang lld llvm python3-pip yamllint + - pip3 install dtschema + script: + - drivers/gpu/drm/ci/${SCRIPT_NAME} + artifacts: + when: on_failure + paths: + - ${ARTIFACT_FILE} + allow_failure: + exit_codes: + - 102 + +dtbs-check:arm32: + extends: + - .build:arm32 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dtbs-check:arm64: + extends: + - .build:arm64 + - .dt-check-base + variables: + SCRIPT_NAME: "dtbs-check.sh" + ARTIFACT_FILE: "dtbs-check.log" + +dt-binding-check: + extends: + - .build + - .use-debian/x86_64_build + - .dt-check-base + variables: + SCRIPT_NAME: "dt-binding-check.sh" + ARTIFACT_FILE: "dt-binding-check.log" diff --git a/drivers/gpu/drm/ci/dt-binding-check.sh b/drivers/gpu/drm/ci/dt-binding-check.sh new file mode 100755 index 000000000000..5e9a439c48a4 --- /dev/null +++ b/drivers/gpu/drm/ci/dt-binding-check.sh @@ -0,0 +1,16 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +if ! make -j"${FDO_CI_CONCURRENT:-4}" dt_binding_check \ + DT_SCHEMA_FILES="${SCHEMA:-}" 2>dt-binding-check.log; then + echo "ERROR: 'make dt_binding_check' failed. Please check dt-binding-check.log for details." + exit 1 +fi + +if [[ -s dt-binding-check.log ]]; then + echo "WARNING: dt_binding_check reported warnings. Please check dt-binding-check.log" \ + "for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/dtbs-check.sh b/drivers/gpu/drm/ci/dtbs-check.sh new file mode 100755 index 000000000000..91212f19fb98 --- /dev/null +++ b/drivers/gpu/drm/ci/dtbs-check.sh @@ -0,0 +1,19 @@ +#!/bin/bash +# SPDX-License-Identifier: MIT + +set -euxo pipefail + +: "${KERNEL_ARCH:?ERROR: KERNEL_ARCH must be set}" + +make LLVM=1 ARCH="${KERNEL_ARCH}" defconfig + +if ! make -j"${FDO_CI_CONCURRENT:-4}" ARCH="${KERNEL_ARCH}" LLVM=1 dtbs_check \ + DT_SCHEMA_FILES="${SCHEMA:-}" 2>dtbs-check.log; then + echo "ERROR: 'make dtbs_check' failed. Please check dtbs-check.log for details." + exit 1 +fi + +if [[ -s dtbs-check.log ]]; then + echo "WARNING: dtbs_check reported warnings. Please check dtbs-check.log for details." + exit 102 +fi diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml index 65adcd97e06b..9e61b49e9960 100644 --- a/drivers/gpu/drm/ci/gitlab-ci.yml +++ b/drivers/gpu/drm/ci/gitlab-ci.yml @@ -108,6 +108,7 @@ include: - drivers/gpu/drm/ci/static-checks.yml - drivers/gpu/drm/ci/build.yml - drivers/gpu/drm/ci/test.yml + - drivers/gpu/drm/ci/check-devicetrees.yml - 'https://gitlab.freedesktop.org/gfx-ci/lab-status/-/raw/main/lab-status.yml'