[v2] drm: clean up comments in drm_crtc.c

Commit Message

Randy Dunlap Jan. 4, 2018, 7:32 p.m. UTC

From: Randy Dunlap <[e-mail]>

Fix typos, punctuation, and one function reference (change
atomic_check two times to be atomic_check and atomic_commit).

Signed-off-by: Randy Dunlap <[e-mail]>
Cc:	David Airlie <[e-mail]>
Cc:	[e-mail]
---
v2: s/instances/instance/ (thanks, Alex)

I was looking for what CRTC means, but I still haven't found it. :(

 drivers/gpu/drm/drm_crtc.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Rodrigo Vivi Jan. 5, 2018, 6:35 p.m. UTC | #1

On Thu, Jan 04, 2018 at 07:32:12PM +0000, Randy Dunlap wrote:
> From: Randy Dunlap <[e-mail]>
> 
> Fix typos, punctuation, and one function reference (change
> atomic_check two times to be atomic_check and atomic_commit).
> 
> Signed-off-by: Randy Dunlap <[e-mail]>
> Cc:	David Airlie <[e-mail]>
> Cc:	[e-mail]

Reviewed-by: Rodrigo Vivi <[e-mail]>

> ---
> v2: s/instances/instance/ (thanks, Alex)
> 
> I was looking for what CRTC means, but I still haven't found it. :(
> 
>  drivers/gpu/drm/drm_crtc.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> --- lnx-415-rc6.orig/drivers/gpu/drm/drm_crtc.c
> +++ lnx-415-rc6/drivers/gpu/drm/drm_crtc.c
> @@ -55,16 +55,16 @@
>   * to one or more &drm_encoder, which are then each connected to one
>   * &drm_connector.
>   *
> - * To create a CRTC, a KMS drivers allocates and zeroes an instances of
> + * To create a CRTC, a KMS driver allocates and zeroes an instance of
>   * &struct drm_crtc (possibly as part of a larger structure) and registers it
>   * with a call to drm_crtc_init_with_planes().
>   *
> - * The CRTC is also the entry point for legacy modeset operations, see
> - * &drm_crtc_funcs.set_config, legacy plane operations, see
> - * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2, and other legacy
> + * The CRTC is also the entry point for legacy modeset operations (see
> + * &drm_crtc_funcs.set_config), legacy plane operations (see
> + * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2), and other legacy
>   * operations like &drm_crtc_funcs.gamma_set. For atomic drivers all these
>   * features are controlled through &drm_property and
> - * &drm_mode_config_funcs.atomic_check and &drm_mode_config_funcs.atomic_check.
> + * &drm_mode_config_funcs.atomic_check and &drm_mode_config_funcs.atomic_commit.
>   */
>  
>  /**
> 
> 
> _______________________________________________
> dri-devel mailing list
> [e-mail]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

--- lnx-415-rc6.orig/drivers/gpu/drm/drm_crtc.c
+++ lnx-415-rc6/drivers/gpu/drm/drm_crtc.c
@@ -55,16 +55,16 @@ 
  * to one or more &drm_encoder, which are then each connected to one
  * &drm_connector.
  *
- * To create a CRTC, a KMS drivers allocates and zeroes an instances of
+ * To create a CRTC, a KMS driver allocates and zeroes an instance of
  * &struct drm_crtc (possibly as part of a larger structure) and registers it
  * with a call to drm_crtc_init_with_planes().
  *
- * The CRTC is also the entry point for legacy modeset operations, see
- * &drm_crtc_funcs.set_config, legacy plane operations, see
- * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2, and other legacy
+ * The CRTC is also the entry point for legacy modeset operations (see
+ * &drm_crtc_funcs.set_config), legacy plane operations (see
+ * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2), and other legacy
  * operations like &drm_crtc_funcs.gamma_set. For atomic drivers all these
  * features are controlled through &drm_property and
- * &drm_mode_config_funcs.atomic_check and &drm_mode_config_funcs.atomic_check.
+ * &drm_mode_config_funcs.atomic_check and &drm_mode_config_funcs.atomic_commit.
  */
 
 /**