From patchwork Thu Feb 15 09:40:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 10220741 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1565B601E7 for ; Thu, 15 Feb 2018 09:40:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A2102903A for ; Thu, 15 Feb 2018 09:40:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F222B290DA; Thu, 15 Feb 2018 09:40:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8C77B2903A for ; Thu, 15 Feb 2018 09:40:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C36996E2F0; Thu, 15 Feb 2018 09:40:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76E086E010 for ; Thu, 15 Feb 2018 09:40:17 +0000 (UTC) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1F9e92m047977 for ; Thu, 15 Feb 2018 04:40:14 -0500 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g54e5f2xf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 15 Feb 2018 04:40:14 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 15 Feb 2018 09:40:09 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 15 Feb 2018 09:40:05 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1F9e5vn524694; Thu, 15 Feb 2018 09:40:05 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B64BF11C05C; Thu, 15 Feb 2018 09:33:16 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CE2211C04C; Thu, 15 Feb 2018 09:33:16 +0000 (GMT) Received: from oc7330422307.ibm.com (unknown [9.152.224.153]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 15 Feb 2018 09:33:16 +0000 (GMT) Subject: Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support To: Bartlomiej Zolnierkiewicz References: <246f92c9-15dc-223f-59d9-b2f0756cdf5e@de.ibm.com> <1610039.4trOurtpys@amdc3058> From: Christian Borntraeger Date: Thu, 15 Feb 2018 10:40:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1610039.4trOurtpys@amdc3058> Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18021509-0008-0000-0000-000004CD0015 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021509-0009-0000-0000-00001E60C811 Message-Id: <2324e2cc-ff55-4d57-2807-c7f72f9ea0ca@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-15_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802150121 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, Chen Liqin , Richard Weinberger , Jeff Dike , Farhan Ali , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, stefan.kristiansson@saunalahti.fi, tomi.valkeinen@ti.com, geert@linux-m68k.org, schwidefsky@de.ibm.com, Lennox Wu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 02/08/2018 02:11 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > [ dri-devel ML & arch/[score,um] Maintainers added to Cc: ] > > On Friday, February 02, 2018 08:59:57 AM Christian Borntraeger wrote: >> On 02/01/2018 07:41 PM, Farhan Ali wrote: >>> The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' >>> added the HAS_IOMEM dependecy for "Graphics support". This disabled the >>> "Graphics support" menu for S390. But if we enable VT layer for S390, >>> we would also need to enable the dummy console. So let's remove the >>> HAS_IOMEM dependency. >>> >>> Move this dependency to Opencores framebuffer driver which would fail to build >>> with CONFIG_HAS_IOMEM disabled: >>> >>> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined! > > "Graphics support" menu covers other things (i.e. DRM), I assume that > they were also checked to not break due to this change? > > Moreover it seems that after this change "Graphics support" menu will > be also enabled (besides s390) for score, tile and um architectures, > I assume that this is okay? Turns out that patch fails to build with. So what about the following approach instead: diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 3c20af999893..5ae512fe52ed 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -47,3 +47,28 @@ endif endmenu + +config DUMMY_CONSOLE + bool + depends on VGA_CONSOLE!=y || SGI_NEWPORT_CONSOLE!=y + default y + +config DUMMY_CONSOLE_COLUMNS + int "Initial number of console screen columns" + depends on DUMMY_CONSOLE && !ARM + default 160 if PARISC + default 80 + help + On PA-RISC, the default value is 160, which should fit a 1280x1024 + monitor. + Select 80 if you use a 640x480 resolution by default. + +config DUMMY_CONSOLE_ROWS + int "Initial number of console screen rows" + depends on DUMMY_CONSOLE && !ARM + default 64 if PARISC + default 25 + help + On PA-RISC, the default value is 64, which should fit a 1280x1024 + monitor. + Select 25 if you use a 640x480 resolution by default. diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index 7f1f1fbcef9e..97ae3c349666 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -91,31 +91,6 @@ config SGI_NEWPORT_CONSOLE Say Y here if you want the console on the Newport aka XL graphics card of your Indy. Most people say Y here. -config DUMMY_CONSOLE - bool - depends on VGA_CONSOLE!=y || SGI_NEWPORT_CONSOLE!=y - default y - -config DUMMY_CONSOLE_COLUMNS - int "Initial number of console screen columns" - depends on DUMMY_CONSOLE && !ARM - default 160 if PARISC - default 80 - help - On PA-RISC, the default value is 160, which should fit a 1280x1024 - monitor. - Select 80 if you use a 640x480 resolution by default. - -config DUMMY_CONSOLE_ROWS - int "Initial number of console screen rows" - depends on DUMMY_CONSOLE && !ARM - default 64 if PARISC - default 25 - help - On PA-RISC, the default value is 64, which should fit a 1280x1024 - monitor. - Select 25 if you use a 640x480 resolution by default. - config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" depends on FB && !UML