| Message ID | 246b8bd6e51ed5c8cb3618f4259adf8aba319511.1611802321.git.xji@analogixsemi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add MIPI rx DPI support | expand |
Hey Xin, On Thu, 28 Jan 2021 at 04:10, Xin Ji <xji@analogixsemi.com> wrote: > > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index c789784..048deec 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,24 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + analogix,lane0-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane0 PHY, please don't > + add this property, or contact vendor. > + > + analogix,lane1-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane1 PHY, please don't > + add this property, or contact vendor. > + > + analogix,hdcp-support: > + type: boolean > + description: indicate the DP tx HDCP support or not. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -41,13 +59,45 @@ properties: > port@0: > $ref: /schemas/graph.yaml#/properties/port > description: > - Video port for MIPI DSI input. > + Video port for MIPI input. Maybe MIPI DSI/DPI input is more correct, since there are a lot of other MIPI standards. > + > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + # Properties described in > + # Documentation/devicetree/bindings/media/video-interfaces.txt > + properties: > + remote-endpoint: true > + bus-type: true > + data-lanes: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: > Video port for panel or connector. > > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + # Properties described in > + # Documentation/devicetree/bindings/media/video-interfaces.txt > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -81,6 +131,8 @@ examples: > reg = <0>; > anx7625_in: endpoint { > remote-endpoint = <&mipi_dsi>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; > > -- > 2.7.4 >
On Thu, Feb 04, 2021 at 01:38:36PM +0100, Robert Foss wrote: > Hey Xin, > > On Thu, 28 Jan 2021 at 04:10, Xin Ji <xji@analogixsemi.com> wrote: > > > > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > > flag and DP tx lane0 and lane1 swing register array define. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++- > > 1 file changed, 53 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index c789784..048deec 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -34,6 +34,24 @@ properties: > > description: used for reset chip control, RESET_N pin B7. > > maxItems: 1 > > > > + analogix,lane0-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane0 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,lane1-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane1 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,hdcp-support: > > + type: boolean > > + description: indicate the DP tx HDCP support or not. > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > @@ -41,13 +59,45 @@ properties: > > port@0: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > - Video port for MIPI DSI input. > > + Video port for MIPI input. > > Maybe MIPI DSI/DPI input is more correct, since there are a lot of > other MIPI standards. Hi Rob, OK, I'll change it in the next series. Thanks, Xin > > > + > > + properties: > > + endpoint: > > + type: object > > + additionalProperties: false > > + > > + # Properties described in > > + # Documentation/devicetree/bindings/media/video-interfaces.txt > > + properties: > > + remote-endpoint: true > > + bus-type: true > > + data-lanes: true > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > Video port for panel or connector. > > > > + properties: > > + endpoint: > > + type: object > > + additionalProperties: false > > + > > + # Properties described in > > + # Documentation/devicetree/bindings/media/video-interfaces.txt > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > required: > > - port@0 > > - port@1 > > @@ -81,6 +131,8 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > -- > > 2.7.4 > >
On Thu, Jan 28, 2021 at 11:08:26AM +0800, Xin Ji wrote: > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > flag and DP tx lane0 and lane1 swing register array define. > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index c789784..048deec 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,24 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + analogix,lane0-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane0 PHY, please don't > + add this property, or contact vendor. > + > + analogix,lane1-swing: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 20 > + description: > + an array of swing register setting for DP tx lane1 PHY, please don't > + add this property, or contact vendor. > + > + analogix,hdcp-support: > + type: boolean > + description: indicate the DP tx HDCP support or not. Please show the new properties in the example. > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > > @@ -41,13 +59,45 @@ properties: > port@0: > $ref: /schemas/graph.yaml#/properties/port > description: > - Video port for MIPI DSI input. > + Video port for MIPI input. > + > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + # Properties described in > + # Documentation/devicetree/bindings/media/video-interfaces.txt Now video-interfaces.yaml which should have a $ref here. It's currently in media tree and linux-next. Follow the examples there. You'll also have to wait for 5.12-rc1 to apply to drm-misc. > + properties: > + remote-endpoint: true > + bus-type: true > + data-lanes: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: > Video port for panel or connector. > > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + # Properties described in > + # Documentation/devicetree/bindings/media/video-interfaces.txt > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > required: > - port@0 > - port@1 > @@ -81,6 +131,8 @@ examples: > reg = <0>; > anx7625_in: endpoint { > remote-endpoint = <&mipi_dsi>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; > > -- > 2.7.4 >
Hi Rob Herring, thanks for the comments. On Tue, Feb 09, 2021 at 01:30:10PM -0600, Rob Herring wrote: > On Thu, Jan 28, 2021 at 11:08:26AM +0800, Xin Ji wrote: > > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support > > flag and DP tx lane0 and lane1 swing register array define. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++- > > 1 file changed, 53 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index c789784..048deec 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > @@ -34,6 +34,24 @@ properties: > > description: used for reset chip control, RESET_N pin B7. > > maxItems: 1 > > > > + analogix,lane0-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane0 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,lane1-swing: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + maxItems: 20 > > + description: > > + an array of swing register setting for DP tx lane1 PHY, please don't > > + add this property, or contact vendor. > > + > > + analogix,hdcp-support: > > + type: boolean > > + description: indicate the DP tx HDCP support or not. > > Please show the new properties in the example. OK, I'll add it in the example. > > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > > > @@ -41,13 +59,45 @@ properties: > > port@0: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > - Video port for MIPI DSI input. > > + Video port for MIPI input. > > + > > + properties: > > + endpoint: > > + type: object > > + additionalProperties: false > > + > > + # Properties described in > > + # Documentation/devicetree/bindings/media/video-interfaces.txt > > Now video-interfaces.yaml which should have a $ref here. It's currently > in media tree and linux-next. Follow the examples there. You'll also > have to wait for 5.12-rc1 to apply to drm-misc. OK. > > > + properties: > > + remote-endpoint: true > > + bus-type: true > > + data-lanes: true > > + > > + required: > > + - remote-endpoint > > + > > + required: > > + - endpoint > > + > > > > port@1: > > $ref: /schemas/graph.yaml#/properties/port > > description: > > Video port for panel or connector. > > > > + properties: > > + endpoint: > > + type: object > > + additionalProperties: false > > + > > + # Properties described in > > + # Documentation/devicetree/bindings/media/video-interfaces.txt > > + properties: > > + remote-endpoint: true > > + > > + required: > > + - remote-endpoint > > + > > required: > > - port@0 > > - port@1 > > @@ -81,6 +131,8 @@ examples: > > reg = <0>; > > anx7625_in: endpoint { > > remote-endpoint = <&mipi_dsi>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > -- > > 2.7.4 > >
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml index c789784..048deec 100644 --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml @@ -34,6 +34,24 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1 + analogix,lane0-swing: + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 20 + description: + an array of swing register setting for DP tx lane0 PHY, please don't + add this property, or contact vendor. + + analogix,lane1-swing: + $ref: /schemas/types.yaml#/definitions/uint32-array + maxItems: 20 + description: + an array of swing register setting for DP tx lane1 PHY, please don't + add this property, or contact vendor. + + analogix,hdcp-support: + type: boolean + description: indicate the DP tx HDCP support or not. + ports: $ref: /schemas/graph.yaml#/properties/ports @@ -41,13 +59,45 @@ properties: port@0: $ref: /schemas/graph.yaml#/properties/port description: - Video port for MIPI DSI input. + Video port for MIPI input. + + properties: + endpoint: + type: object + additionalProperties: false + + # Properties described in + # Documentation/devicetree/bindings/media/video-interfaces.txt + properties: + remote-endpoint: true + bus-type: true + data-lanes: true + + required: + - remote-endpoint + + required: + - endpoint + port@1: $ref: /schemas/graph.yaml#/properties/port description: Video port for panel or connector. + properties: + endpoint: + type: object + additionalProperties: false + + # Properties described in + # Documentation/devicetree/bindings/media/video-interfaces.txt + properties: + remote-endpoint: true + + required: + - remote-endpoint + required: - port@0 - port@1 @@ -81,6 +131,8 @@ examples: reg = <0>; anx7625_in: endpoint { remote-endpoint = <&mipi_dsi>; + bus-type = <5>; + data-lanes = <0 1 2 3>; }; };
Add 'bus-type' and 'data-lanes' define for port0, add HDCP support flag and DP tx lane0 and lane1 swing register array define. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-)