From patchwork Wed Mar 28 10:29:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Andrushchenko X-Patchwork-Id: 10312743 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34DA260467 for ; Wed, 28 Mar 2018 10:29:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 335B029EE4 for ; Wed, 28 Mar 2018 10:29:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2661229EED; Wed, 28 Mar 2018 10:29:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9EA3A29EE4 for ; Wed, 28 Mar 2018 10:29:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E01406E263; Wed, 28 Mar 2018 10:29:51 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F9746E263 for ; Wed, 28 Mar 2018 10:29:50 +0000 (UTC) Received: by mail-lf0-x231.google.com with SMTP id v207-v6so2718290lfa.10 for ; Wed, 28 Mar 2018 03:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=e/N7dZc2h5BieAMTuwdKpd0rTq1WuoNbVaaVG7iKg34=; b=Na1zrpmycUPglNR+809P+MS2AWRPYM/N8CB3wrK3UisvxFypDEP6Gxc2itIPWJXPv3 EAkTtxws2SnPYGswXu/lTd1yNZIkW1u5bF3t8jmDygIlwMDEoOklXm5tcoKFVHFSp/oU TNqaFWFcSXVWRq8VY9Pmvg8s3olq99lN7sYMWZj8KDsEh1dGG4jp6jSQ1FJX5BQAVn4T NYO6Zjc5WtoDrxXmy0Pl8kyh4aMoa1iYiTv+BXB5NIVWcgYz2sPcWa9L0siZLrcNi4NF ytIvEvy1RxENbz6uXaLAkyyrxlwBRytLJnaZKjph/s+o/31qNBYrB8feM+ynl7NBh6EW XUXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=e/N7dZc2h5BieAMTuwdKpd0rTq1WuoNbVaaVG7iKg34=; b=U1J+zSebryy0aH4TBnVj7ikijLhRRSOHw6MUNdv78CMD79EwEfcVAnaVnIYkKq9ME2 +D1UuM6AH+JPUax0jFAggzJrzw5sYIIM2OaBsiB4lZkE9a0KreEzK6ZOKYKsexUrMarn Fx7rExOR3XXvUmgsrZdnXtOrTuvKuioLvtOLzplAh5eSHap9jZyQsUbFim1+0OYuH2Vd Jed18CcXEnoYliLlCHDGC40guVMbmwVY6ehyNr2gGYTzunuKREq5yljOuTxx6u3UJmg1 UyiwGEBBSuDbHI0Ys9sTVYtWXKzSe7m5wqLx1B6zQsKt7SZR7bmqElJZgJfPWD9fGl57 svnA== X-Gm-Message-State: AElRT7GxVdSYdDK8CH6XifKJNGneRMFwM5rS5w+BCf2rjxXRWZwOT4nE tewIHqkOU+gNHdukhz3YnCg= X-Google-Smtp-Source: AIpwx4/2gyvGbcMmIeQou5H+554F4N5H1u3GTFTypF+gFl58IyGXU53D2YjuLQFl7Qx586WXo8xpgw== X-Received: by 10.46.42.67 with SMTP id q64mr2115468ljq.133.1522232988539; Wed, 28 Mar 2018 03:29:48 -0700 (PDT) Received: from [10.17.182.9] (ll-55.209.223.85.sovam.net.ua. [85.223.209.55]) by smtp.gmail.com with ESMTPSA id q24sm557760ljj.68.2018.03.28.03.29.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 03:29:47 -0700 (PDT) Subject: Re: [PATCH v4 2/2] drm/xen-front: Add support for Xen PV display frontend To: daniel.vetter@intel.com References: <1522219661-26827-1-git-send-email-andr2000@gmail.com> <1522219661-26827-3-git-send-email-andr2000@gmail.com> <20180328074251.GE14155@phenom.ffwll.local> From: Oleksandr Andrushchenko Message-ID: <32481355-27f6-695b-c6c1-8113ea268a33@gmail.com> Date: Wed, 28 Mar 2018 13:29:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328074251.GE14155@phenom.ffwll.local> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, konrad.wilk@oracle.com, airlied@linux.ie, Oleksandr Andrushchenko , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, Daniel! I just noticed I have missed one change in the patch: the below must be static. On 03/28/2018 10:42 AM, Daniel Vetter wrote: > +enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, > + const struct drm_display_mode *mode) > +{ > + struct xen_drm_front_drm_pipeline *pipeline = > + container_of(crtc, Could you please amend the patch in attachment when merging, so I don't resend? Thank you in advance, Oleksandr From 3a82d76bd3d954056b760e5d1d09e2f96a2786ef Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko Date: Wed, 28 Mar 2018 13:24:04 +0300 Subject: [PATCH] drm/xen-front: Make display_mode_valid static Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms.c b/drivers/gpu/drm/xen/xen_drm_front_kms.c index 545049dfaf0a..bd676be5a0db 100644 --- a/drivers/gpu/drm/xen/xen_drm_front_kms.c +++ b/drivers/gpu/drm/xen/xen_drm_front_kms.c @@ -273,7 +273,7 @@ static void display_update(struct drm_simple_display_pipe *pipe, drm_dev_exit(idx); } -enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, +static enum drm_mode_status display_mode_valid(struct drm_crtc *crtc, const struct drm_display_mode *mode) { struct xen_drm_front_drm_pipeline *pipeline = -- 2.7.4