From patchwork Tue May 23 00:14:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 9741641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AC11960210 for ; Tue, 23 May 2017 01:01:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A19F8286EC for ; Tue, 23 May 2017 01:01:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 968F928779; Tue, 23 May 2017 01:01:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56E0F286EC for ; Tue, 23 May 2017 01:01:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A0B826E304; Tue, 23 May 2017 01:00:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 345C989CA1 for ; Tue, 23 May 2017 00:15:24 +0000 (UTC) Received: by mail-lf0-x244.google.com with SMTP id m18so6671200lfj.0 for ; Mon, 22 May 2017 17:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=7HTUokyDfSpjlZ48Xi9GmlDQqcmhkseitG17e8J7rOg=; b=hi4wV5VBPFuV+EIaQ2xXuQ/zgDxChwf/+UOCVX9bSDtjnntuglu6oYv7G3hPmZLAZA lE/n3sJo/cb9hjMx9ZaAdH8QllIIC2uELPM1mw6uSF6QsClaflPJ5ZWqPWa5395YVhD2 nWv0Jk6JqPc4G1vshtNot22knJCCqUv5GIO9fk4mwMbGkJyKUG2Zi5SENLxJl1fuf8bq excHnySjV7oTdz0vvPlJIFG4uqlNfyqGIgcf1JOYGuJc17/7/wOCzMEYsQYm6mMfv3Ms zOMHsk77E98ws9dOHVSWuFtYg0jGx99cpyN3W2e/b0NEKJmbbfoeIvBPkNsYPOLfiYpv U0mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=7HTUokyDfSpjlZ48Xi9GmlDQqcmhkseitG17e8J7rOg=; b=pn8OibJTZmRG2nfnJaVRvGmoHoBAgVixl9iywlEPkgLPgrFSloKmZaXxPEZ4s/MeF+ rkLriFCUKvcF7hpbNS1wjMypjyX2KIJWro5RiiJXlIUpx6jcWa+YaiW9NVHan+M7QXgf 6Ax9iuMSe6Jicclox6mLE7Y3xko0tJLiVtjc04MVKS0i40WyqCrSKWNs0dUbtBN/gNsr YB42p0xJH8PRJRU10w5TycAzVGL+AlbrcsFiWk4wwYdJywRJGTRRVrw5tftDkvm/KLR8 Zrjtw15wMNlJfcVw1Zux80goI/FlNZaW8W3kgH6z4xoml+Th1nlYOysiET4M/+6IEd6o 3udQ== X-Gm-Message-State: AODbwcA/vmpk+G75MyX5Crtdf2U4Icbv0x+V65ZeK80qWVwudZwUNS0G WCN7sA57mJLTJhuFeGM= X-Received: by 10.25.206.77 with SMTP id e74mr6793475lfg.73.1495498522707; Mon, 22 May 2017 17:15:22 -0700 (PDT) Received: from localhost.localdomain (ppp109-252-91-175.pppoe.spdop.ru. [109.252.91.175]) by smtp.gmail.com with ESMTPSA id v30sm3440904ljd.9.2017.05.22.17.15.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 17:15:22 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Mikko Perttunen Subject: [PATCH 08/22] drm/tegra: dc: Drop the reset asserts to workaround a bug Date: Tue, 23 May 2017 03:14:23 +0300 Message-Id: <35e1ef44da98701b2c507c31ecc0812530303d2d.1495498184.git.digetx@gmail.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: References: In-Reply-To: References: X-Mailman-Approved-At: Tue, 23 May 2017 00:59:38 +0000 Cc: linux-tegra@vger.kernel.org, DRI Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 33a8eb8 ("Implement runtime PM") introduced HW reset control. It causes a hang on Tegra20 if both display controllers are utilized (RGB panel and HDMI). The TRM suggests that each display controller has its own reset control, apparently it is not correct. Let's remove the interaction with the resets for now as a workaround. Fixes: 33a8eb8d40ee ("drm/tegra: dc: Implement runtime PM") Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/dc.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 95b373f739f2..5c9b93981af2 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -1989,8 +1989,6 @@ static int tegra_dc_probe(struct platform_device *pdev) return PTR_ERR(dc->rst); } - reset_control_assert(dc->rst); - if (dc->soc->has_powergate) { if (dc->pipe == 0) dc->powergate = TEGRA_POWERGATE_DIS; @@ -2061,13 +2059,6 @@ static int tegra_dc_remove(struct platform_device *pdev) static int tegra_dc_suspend(struct device *dev) { struct tegra_dc *dc = dev_get_drvdata(dev); - int err; - - err = reset_control_assert(dc->rst); - if (err < 0) { - dev_err(dev, "failed to assert reset: %d\n", err); - return err; - } if (dc->soc->has_powergate) tegra_powergate_power_off(dc->powergate); @@ -2095,12 +2086,6 @@ static int tegra_dc_resume(struct device *dev) dev_err(dev, "failed to enable clock: %d\n", err); return err; } - - err = reset_control_deassert(dc->rst); - if (err < 0) { - dev_err(dev, "failed to deassert reset: %d\n", err); - return err; - } } return 0;