| Message ID | 360728864e7aae4b839877d0bc49109fcf8dd14e.1599165521.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/etnaviv: Drop local dma_parms | expand |
On Do, 2020-09-03 at 21:40 +0100, Robin Murphy wrote: > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms > for platform devices"), struct platform_device already provides a > dma_parms structure, so we can save allocating another one. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> Thanks, applied to etnaviv/next. Regards, Lucas > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 --- > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index a9a3afaef9a1..79b3bcd9f444 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -535,7 +535,6 @@ static int etnaviv_bind(struct device *dev) > } > drm->dev_private = priv; > > - dev->dma_parms = &priv->dma_parms; > dma_set_max_seg_size(dev, SZ_2G); > > mutex_init(&priv->gem_lock); > @@ -585,8 +584,6 @@ static void etnaviv_unbind(struct device *dev) > > component_unbind_all(dev, drm); > > - dev->dma_parms = NULL; > - > etnaviv_cmdbuf_suballoc_destroy(priv->cmdbuf_suballoc); > > drm->dev_private = NULL; > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > index 4d8dc9236e5f..7db607817c0c 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h > @@ -33,7 +33,6 @@ struct etnaviv_file_private { > > struct etnaviv_drm_private { > int num_gpus; > - struct device_dma_parameters dma_parms; > struct etnaviv_gpu *gpu[ETNA_MAX_PIPES]; > gfp_t shm_gfp_mask; >
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index a9a3afaef9a1..79b3bcd9f444 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -535,7 +535,6 @@ static int etnaviv_bind(struct device *dev) } drm->dev_private = priv; - dev->dma_parms = &priv->dma_parms; dma_set_max_seg_size(dev, SZ_2G); mutex_init(&priv->gem_lock); @@ -585,8 +584,6 @@ static void etnaviv_unbind(struct device *dev) component_unbind_all(dev, drm); - dev->dma_parms = NULL; - etnaviv_cmdbuf_suballoc_destroy(priv->cmdbuf_suballoc); drm->dev_private = NULL; diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h index 4d8dc9236e5f..7db607817c0c 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h @@ -33,7 +33,6 @@ struct etnaviv_file_private { struct etnaviv_drm_private { int num_gpus; - struct device_dma_parameters dma_parms; struct etnaviv_gpu *gpu[ETNA_MAX_PIPES]; gfp_t shm_gfp_mask;
Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms for platform devices"), struct platform_device already provides a dma_parms structure, so we can save allocating another one. Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 --- drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 - 2 files changed, 4 deletions(-)