From patchwork Fri Jan 1 14:09:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7939361 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6BCEBBEEE5 for ; Fri, 1 Jan 2016 14:09:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9D8F6205EA for ; Fri, 1 Jan 2016 14:09:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C45EB205E5 for ; Fri, 1 Jan 2016 14:09:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BFD56E39E; Fri, 1 Jan 2016 06:09:19 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82B656E39E for ; Fri, 1 Jan 2016 06:09:18 -0800 (PST) Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0LbItu-1Zq9AZ0j86-00kyzo; Fri, 01 Jan 2016 15:09:13 +0100 From: Arnd Bergmann To: David Airlie Subject: [PATCH] drm: arm-hdlcd: remove DMA_CMA select Date: Fri, 01 Jan 2016 15:09:10 +0100 Message-ID: <4194408.X82ccDjh5X@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:4GATCPMOMhd6TEJjOt7r8xYjJ9/kq00a7U1vPoSe8Itss2RhnI+ wyAv3Dbl4AuUSO8lgh2zw+lJZh14lhMFV6g76MeIFPr9oJZMZBxsUZDMXcF/6wm25z44UoY cx0Nig1OZxvTLjwX30p9t/+GOiV3lVCeQ1+0O2OARex93zEB+d8YoTkQruB024H1jpptBTl ghuFM+RGTP3ernvj66pNg== X-UI-Out-Filterresults: notjunk:1; V01:K0:g4tHiz6I+j4=:RU3QsbuQiDEAX2711Zf6f+ yDFcQ+nvAZJoZBHIlICiZc/XlxoHx8QVy84s+BXbb2BV+oItrZfORc5yPmZp+JteMxv5hKYHH IkP9Sga95JB3FLpMwXDVV5g+JvmLoijCV2aN80Kz2VzJaYhmdLbVhRywrBHrFDrK1LXMmab7C 9SsH5RiLKsiHiZXDfs3hVocOGak3N/a4umh0uakApaRapcpS8CYVwyrsLa1ZSnOeRKL4BsbII i0bJZ6ec9M3+EIORB66/BrWKI1xEb+Ug5toBKh3YC/iE1cHY3sOp8adwdQWQ8nd43u/YUGXX6 znoa3+QUtAJA4RD04OS2JD+lWjumN24d9jH6T/AK0L3QGRVcXnKVSpdX/9SjQhrXWJB4nXBFS 9GOb0/dQ4nEsSQzqcGql6nMybwVFKqIJUPUTr4rJoFhd++6wlPsc1c63Is7RMepkSQCGB1/L4 baISKxJBEeOqkOmu84YrbTkXPeZkdHVcKFmbD7fSoemO/eOkwkMejEckMO4Rj5iXVjqK8rJfG +u6LUdpeJYS5xg/tUIIknCVKPJ1pBYcK2oiqwgTpF34ccCKjD4uuPQYr6MJeM6hhxfc5KmeC4 j1oWXxbaKBrUvtGqFRBaCLFlaozDEgAjNjq7fx92pPckvTQ4YpZ9EJYH7Z3kGTGGskjLidc55 j0RTWQ5q/Rgs87FEjsJXbcRxlOaV1ASQlC+HDhVTYSpCBfuwhMtPEP4+AAw7EJEd4872T+ZaG zHH9iFDL5NpjSfR/ Cc: linux-arm-kernel@lists.infradead.org, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is not necessarily possible, as not all configurations contain HAVE_DMA_CONTIGUOUS: warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies (HAVE_DMA_CONTIGUOUS && CMA) drivers/built-in.o: In function `dma_alloc_from_contiguous': :(.text+0x1dee00): undefined reference to `cma_alloc' drivers/built-in.o: In function `dma_release_from_contiguous': :(.text+0x1dee24): undefined reference to `cma_release' This removes the 'select' statement. It is not needed because CMA is meant to transparently change the behavior of dma_alloc_coherent to make it succeed for larger allocations, but there is no actual build-time dependency, and the driver can still work without CMA in many cases. Signed-off-by: Arnd Bergmann Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.") Reviewed-by: Thierry Reding Acked-by: Liviu Dudau --- Found on ARM randconfig builds with yesterday's linux-next diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 5e8c8a86860b..2f4d3b7fb871 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -10,7 +10,6 @@ config DRM_HDLCD depends on DRM_ARM depends on COMMON_CLK select COMMON_CLK_SCPI - select DMA_CMA select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER help