| Message ID | 43645c9b5cd657664c1340d40133f2116c8cef43.1655818025.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC | expand |
On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote: > The various Freescale i.MX8MP display bridges are only present on > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > asking the user about these drivers when configuring a kernel without > i.MX SoC support. s/i.MX8MP/i.MX8/ For now, only i.MX8qm and i.MX8qxp display bridge drivers are in bridge/imx directory, no i.MX8MP display bridge driver. With this fixed: Reviewed-by: Liu Ying <victor.liu@nxp.com> > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for > i.MX8qm") > Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for > i.MX8qxp") > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to > DPI support") > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display > pixel link support") > Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel > combiner support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Probably the remaining i.MX bridge drivers in > drivers/gpu/drm/bridge/Kconfig (e.g. DRM_FSL_LDB) should be moved > here, > too? DRM_FSL_LDB is for i.MX8MP LVDS Display Bridge(LDB). Here is a kinda appropriate directory for that driver I think, though the filename fsl-ldb.c is perhaps a bit too generic(we have imx8qm-ldb- driver.c and imx8qxp-ldb-driver.c). No other bridge drivers can be moved here, AFAICS. Thanks, Liu Ying > --- > drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig > b/drivers/gpu/drm/bridge/imx/Kconfig > index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -1,3 +1,5 @@ > +if ARCH_MXC || COMPILE_TEST > + > config DRM_IMX8QM_LDB > tristate "Freescale i.MX8QM LVDS display bridge" > depends on OF > @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI > help > Choose this to enable pixel link to display pixel > interface(PXL2DPI) > found in Freescale i.MX8qxp processor. > + > +endif # ARCH_MXC || COMPILE_TEST
Hi Liu, On Tue, Jun 21, 2022 at 5:47 PM Liu Ying <victor.liu@nxp.com> wrote: > On Tue, 2022-06-21 at 15:30 +0200, Geert Uytterhoeven wrote: > > The various Freescale i.MX8MP display bridges are only present on > > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > > asking the user about these drivers when configuring a kernel without > > i.MX SoC support. > > s/i.MX8MP/i.MX8/ Oops. Fixed. > For now, only i.MX8qm and i.MX8qxp display bridge drivers are in > bridge/imx directory, no i.MX8MP display bridge driver. > > With this fixed: > Reviewed-by: Liu Ying <victor.liu@nxp.com> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644 --- a/drivers/gpu/drm/bridge/imx/Kconfig +++ b/drivers/gpu/drm/bridge/imx/Kconfig @@ -1,3 +1,5 @@ +if ARCH_MXC || COMPILE_TEST + config DRM_IMX8QM_LDB tristate "Freescale i.MX8QM LVDS display bridge" depends on OF @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI help Choose this to enable pixel link to display pixel interface(PXL2DPI) found in Freescale i.MX8qxp processor. + +endif # ARCH_MXC || COMPILE_TEST
The various Freescale i.MX8MP display bridges are only present on Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent asking the user about these drivers when configuring a kernel without i.MX SoC support. Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for i.MX8qm") Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for i.MX8qxp") Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to DPI support") Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display pixel link support") Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Probably the remaining i.MX bridge drivers in drivers/gpu/drm/bridge/Kconfig (e.g. DRM_FSL_LDB) should be moved here, too? --- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)