From patchwork Wed Aug 29 04:18:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Pilcher X-Patchwork-Id: 1383571 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id B5F993FDF5 for ; Wed, 29 Aug 2012 04:23:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 542669F365 for ; Tue, 28 Aug 2012 21:23:20 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com [209.85.214.177]) by gabe.freedesktop.org (Postfix) with ESMTP id DFA009E8A0 for ; Tue, 28 Aug 2012 21:18:24 -0700 (PDT) Received: by obbta17 with SMTP id ta17so243952obb.36 for ; Tue, 28 Aug 2012 21:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=CVHKVsycF8laF8RppqY1dx4YlPfkrNt1MwfDvCgwyYA=; b=ZqPNQSXC+bEefi0jqW0cEeNQdNe4IaOUt4zkJhGG3IhjCN/u6/2UHzZ9eCkwZQICZo tEq4TlRqYfxt6W0yPEt/vIxJTX39n+tJymYvG1XHF0h7RV9vSnssEewCJRLSLRdWfATY yPfITXgns7Xh2mXuxUdOCh58UYQYPxT/LuplpFAX5boQqRrj7/jRXvlJpnCd7zXYoUJ+ ir3Jf8mDrbvHDnYHceM3jBsjtuVuIXDD5bHmYj1uI13+U5mB8aznnbdxWsaJccqgB0e3 oqVcmn2+q/uDIu0PYQkD5QPWvO8IFriP3kwOZHxtJfU5J4N68l33Zzxi0/nB8s7lGY4Y YtQw== Received: by 10.60.29.230 with SMTP id n6mr150379oeh.123.1346213904003; Tue, 28 Aug 2012 21:18:24 -0700 (PDT) Received: from ian.icp.selfip.net (pool-71-170-109-80.dllstx.fios.verizon.net. [71.170.109.80]) by mx.google.com with ESMTPS id cp8sm21613465obc.23.2012.08.28.21.18.23 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 28 Aug 2012 21:18:23 -0700 (PDT) Message-ID: <503D9810.60104@gmail.com> Date: Tue, 28 Aug 2012 23:18:24 -0500 From: Ian Pilcher User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Adam Jackson Subject: Re: -next queue and EDID stuff References: <503BD762.6070204@redhat.com> <503D553C.9000503@gmail.com> <503D5EB9.2040405@redhat.com> In-Reply-To: <503D5EB9.2040405@redhat.com> Cc: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org On 08/28/2012 07:13 PM, Adam Jackson wrote: > On 8/28/12 7:33 PM, Ian Pilcher wrote: >> Actually, I believe that the error is probably in the Intel driver. As >> I understand it, it shouldn't be sending audio InfoFrames to a non-HDMI >> display. > > If that's the case then I'd still say "we're doing something else wrong > here". Quirks - at least at the core drm level - are not for working > around broken drivers, they're for working around broken displays. And I'd agree. (Although I suppose one *could* argue that the display is broken in 2 ways -- it reports audio capabilities that aren't really there, and it gets confused by any InfoFrames -- AVI or audio.) I don't have the knowledge or time to fix the Intel driver, but I've always planned to at least bugzilla the issue. I can't reasonably do so, however, until the user-defined quirks infrastructure is in place, so that the behavior can be demonstrated. If you prefer to leave the display broken with Intel GPUs, you can always just remove the EDID_QUIRK_NO_AUDIO flag: * provide some room for user-supplied quirks. --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -160,6 +160,10 @@ union edid_quirk edid_quirk_list[EDID_QUIRK_LIST_SIZE] = { { { { { EDID_MFG_ID('V', 'S', 'C'), cpu_to_le16(5020) } }, EDID_QUIRK_FORCE_REDUCED_BLANKING } }, + /* LG L246WP */ + { { { { EDID_MFG_ID('G', 'S', 'M'), cpu_to_le16(0x563f) } }, + EDID_QUIRK_DISABLE_INFOFRAMES } }, + /* * When adding built-in quirks, please adjust EDID_QUIRK_LIST_SIZE to