| Message ID | 505484b83fedebce3c65b10b076b34df075074b6.1713329988.git.baruch@tkos.co.il (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] doc: dma-buf: fix grammar typo | expand |
Well checkpatch.pl still complained: ERROR: trailing whitespace #157: FILE: Documentation/driver-api/dma-buf.rst:80: + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all^M$ That actually looks like you used a Windows line ending. I fixed it up and pushed the patch, but please take a bit more care next time. Thanks, Christian. Am 17.04.24 um 06:59 schrieb Baruch Siach: > Use 'supported' instead of 'support'. 'support' makes no sense in this > context. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > v2: Add commit log message (Christian König) > --- > Documentation/driver-api/dma-buf.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst > index 0c153d79ccc4..29abf1eebf9f 100644 > --- a/Documentation/driver-api/dma-buf.rst > +++ b/Documentation/driver-api/dma-buf.rst > @@ -77,7 +77,7 @@ consider though: > the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other > llseek operation will report -EINVAL. > > - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all > + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all > cases. Userspace can use this to detect support for discovering the dma-buf > size using llseek. >
Hi Christian, On Thu, Apr 18 2024, Christian König wrote: > Well checkpatch.pl still complained: > > ERROR: trailing whitespace > #157: FILE: Documentation/driver-api/dma-buf.rst:80: > + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for > all^M$ > > That actually looks like you used a Windows line ending. Interesting. I can't reproduce that here: $ hexdump -C 0001-doc-dma-buf-fix-grammar-typo.patch ... 00000490 6f 72 74 20 2d 45 53 50 49 50 45 20 66 6f 72 20 |ort -ESPIPE for | 000004a0 61 6c 6c 0a 20 20 20 63 61 73 65 73 2e 20 55 73 |all. cases. Us| Only a single Unix style EOL character (0x0a) is shown. Same if I dump the email from the archive: curl https://lore.kernel.org/all/505484b83fedebce3c65b10b076b34df075074b6.1713329988.git.baruch@tkos.co.il/raw |hexdump -C ... 00001010 6c 20 72 65 70 6f 72 74 20 2d 45 53 50 49 50 45 |l report -ESPIPE| 00001020 20 66 6f 72 20 61 6c 6c 0a 20 20 20 63 61 73 65 | for all. case| Do you get the same blob hash (29abf1eebf9f) when running git hash-object -t blob Documentation/driver-api/dma-buf.rst on the resulting file before you fixed it? > I fixed it up and pushed the patch, but please take a bit more care next time. Thanks. I'm curious to know what kind of care I should take. baruch > Am 17.04.24 um 06:59 schrieb Baruch Siach: >> Use 'supported' instead of 'support'. 'support' makes no sense in this >> context. >> >> Signed-off-by: Baruch Siach <baruch@tkos.co.il> >> --- >> v2: Add commit log message (Christian König) >> --- >> Documentation/driver-api/dma-buf.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst >> index 0c153d79ccc4..29abf1eebf9f 100644 >> --- a/Documentation/driver-api/dma-buf.rst >> +++ b/Documentation/driver-api/dma-buf.rst >> @@ -77,7 +77,7 @@ consider though: >> the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other >> llseek operation will report -EINVAL. >> - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE >> for all >> + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all >> cases. Userspace can use this to detect support for discovering the dma-buf >> size using llseek. >>
diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst index 0c153d79ccc4..29abf1eebf9f 100644 --- a/Documentation/driver-api/dma-buf.rst +++ b/Documentation/driver-api/dma-buf.rst @@ -77,7 +77,7 @@ consider though: the usual size discover pattern size = SEEK_END(0); SEEK_SET(0). Every other llseek operation will report -EINVAL. - If llseek on dma-buf FDs isn't support the kernel will report -ESPIPE for all + If llseek on dma-buf FDs isn't supported the kernel will report -ESPIPE for all cases. Userspace can use this to detect support for discovering the dma-buf size using llseek.
Use 'supported' instead of 'support'. 'support' makes no sense in this context. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- v2: Add commit log message (Christian König) --- Documentation/driver-api/dma-buf.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)