[PATCHv5,7/8] ARM: tegra: Add board data and 2D clocks

Commit Message

Terje Bergstrom Jan. 16, 2013, 8:10 a.m. UTC

On 15.01.2013 20:44, Stephen Warren wrote:
> On 01/15/2013 04:26 AM, Terje Bergstrom wrote:
>> Add a driver alias gr2d for Tegra 2D device, and assign a duplicate
>> of 2D clock to that driver alias.
> 
> FYI on this one patch - it won't be applied to the Tegra tree until
> after Prashant's common clock framework changes are applied. As such, it
> will need some rework once those patches are applied, or perhaps won't
> even be relevant any more; see below.

It looks like I need to just drop the patch 7(8 "ARM: tegra: Add board
data and 2D clocks" and change the 2D code to access the clock without a
name. Do you agree?

I'll roll this into the next patch version once I've gathered more comments.


Terje

Comments

Stephen Warren Jan. 16, 2013, 5:25 p.m. UTC | #1

On 01/16/2013 01:10 AM, Terje Bergström wrote:
> On 15.01.2013 20:44, Stephen Warren wrote:
>> On 01/15/2013 04:26 AM, Terje Bergstrom wrote:
>>> Add a driver alias gr2d for Tegra 2D device, and assign a duplicate
>>> of 2D clock to that driver alias.
>>
>> FYI on this one patch - it won't be applied to the Tegra tree until
>> after Prashant's common clock framework changes are applied. As such, it
>> will need some rework once those patches are applied, or perhaps won't
>> even be relevant any more; see below.
> 
> It looks like I need to just drop the patch 7(8 "ARM: tegra: Add board
> data and 2D clocks" and change the 2D code to access the clock without a
> name. Do you agree?

That sounds right to me, yes.

Patch

diff --git a/drivers/gpu/host1x/drm/gr2d.c b/drivers/gpu/host1x/drm/gr2d.c
index dc7d6c6..a1c5f5c 100644
--- a/drivers/gpu/host1x/drm/gr2d.c
+++ b/drivers/gpu/host1x/drm/gr2d.c
@@ -259,7 +259,7 @@  static int gr2d_probe(struct platform_device *dev)
        if (!gr2d)
                return -ENOMEM;

-       gr2d->clk = devm_clk_get(&dev->dev, "gr2d");
+       gr2d->clk = devm_clk_get(&dev->dev, NULL);
        if (IS_ERR(gr2d->clk)) {
                dev_err(&dev->dev, "cannot get clock\n");
                return PTR_ERR(gr2d->clk);