From patchwork Tue Mar 5 17:08:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 2223531 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id BC59F3FCF6 for ; Wed, 6 Mar 2013 07:20:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C059EE5CDB for ; Tue, 5 Mar 2013 23:20:30 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FA2BE5FCE for ; Tue, 5 Mar 2013 09:07:46 -0800 (PST) Received: from static-50-53-38-135.bvtn.or.frontiernet.net ([50.53.38.135] helo=dragon.site) by casper.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1UCvL5-0004ES-Tf; Tue, 05 Mar 2013 17:07:44 +0000 Message-ID: <51362680.3030203@infradead.org> Date: Tue, 05 Mar 2013 09:08:16 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: dri-devel@lists.freedesktop.org, Linus Torvalds Subject: [PATCH] drm: fix new kernel-doc warnings X-Mailman-Approved-At: Tue, 05 Mar 2013 22:41:23 -0800 Cc: LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org From: Randy Dunlap Fix new kernel-doc warnings in drm_edid.c: convert doxygen(?) to kernel-doc to match the rest of the file's documentation. Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'buf' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'block' Warning(drivers/gpu/drm/drm_edid.c:997): No description found for parameter 'len' Warning(drivers/gpu/drm/drm_edid.c:1138): No description found for parameter 'adapter' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:1467): No description found for parameter 'revision' Warning(drivers/gpu/drm/drm_edid.c:1467): Excess function parameter 'timing_level' description in 'drm_mode_std' Warning(drivers/gpu/drm/drm_edid.c:2010): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2072): No description found for parameter 'connector' Warning(drivers/gpu/drm/drm_edid.c:2237): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2616): No description found for parameter 'edid' Warning(drivers/gpu/drm/drm_edid.c:2658): No description found for parameter 'edid' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_edid.c | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) --- lnx-39-rc1.orig/drivers/gpu/drm/drm_edid.c +++ lnx-39-rc1/drivers/gpu/drm/drm_edid.c @@ -982,12 +982,13 @@ EXPORT_SYMBOL(drm_edid_is_valid); #define DDC_SEGMENT_ADDR 0x30 /** - * Get EDID information via I2C. + * drm_do_probe_ddc_edid - Get EDID information via I2C. * - * \param adapter : i2c device adaptor - * \param buf : EDID data buffer to be filled - * \param len : EDID data buffer length - * \return 0 on success or -1 on failure. + * @adapter : i2c device adaptor + * @buf : EDID data buffer to be filled + * @block : block number + * @len : EDID data buffer length + * return : 0 on success or -1 on failure. * * Try to fetch EDID information by calling i2c driver function. */ @@ -1128,10 +1129,10 @@ out: } /** - * Probe DDC presence. + * drm_probe_ddc - Probe DDC presence. * - * \param adapter : i2c device adaptor - * \return 1 on success + * @adapter : i2c device adaptor + * return : 1 on success */ bool drm_probe_ddc(struct i2c_adapter *adapter) @@ -1455,8 +1456,10 @@ bad_std_timing(u8 a, u8 b) /** * drm_mode_std - convert standard mode info (width, height, refresh) into mode + * @connector: attached connector + * @edid: EDID block * @t: standard timing params - * @timing_level: standard timing level + * @revision: EDID revision * * Take the standard timing params (in this case width, aspect, and refresh) * and convert them into a real mode using CVT/GTF/DMT. @@ -1999,7 +2002,8 @@ do_established_modes(struct detailed_tim } /** - * add_established_modes - get est. modes from EDID and add them + * add_established_modes - get established modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Each EDID block contains a bitmap of the supported "established modes" list @@ -2062,6 +2066,7 @@ do_standard_modes(struct detailed_timing /** * add_standard_modes - get std. modes from EDID and add them + * @connector: attached connector * @edid: EDID block to scan * * Standard modes can be calculated using the appropriate standard (DMT, @@ -2231,7 +2236,8 @@ add_detailed_modes(struct drm_connector #define EDID_CEA_VCDB_QS (1 << 6) /** - * Search EDID for CEA extension block. + * drm_find_cea_extension - Search EDID for CEA extension block. + * @edid: EDID block to search */ u8 *drm_find_cea_extension(struct edid *edid) { @@ -2604,6 +2610,7 @@ EXPORT_SYMBOL(drm_detect_hdmi_monitor); /** * drm_detect_monitor_audio - check monitor audio capability + * @edid: EDID block * * Monitor should have CEA extension block. * If monitor has 'basic audio', but no CEA audio blocks, it's 'basic @@ -2649,6 +2656,7 @@ EXPORT_SYMBOL(drm_detect_monitor_audio); /** * drm_rgb_quant_range_selectable - is RGB quantization range selectable? + * @edid: EDID block * * Check whether the monitor reports the RGB quantization range selection * as supported. The AVI infoframe can then be used to inform the monitor