diff mbox

drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

Message ID 513C144D.8060008@asianux.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chen Gang March 10, 2013, 5:04 a.m. UTC 
When make with EXTRA_CFLAGS=-W, it will report error.
  so give a check in Makefile.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
---
 drivers/gpu/drm/tilcdc/Makefile |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Comments

Rob Clark March 11, 2013, 2:02 p.m. UTC | #1 
On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang <gang.chen@asianux.com> wrote:
>
>   When make with EXTRA_CFLAGS=-W, it will report error.
>   so give a check in Makefile.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>

Signed-off-by: Rob Clark <robdclark@gmail.com>

> ---
>  drivers/gpu/drm/tilcdc/Makefile |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile
> index deda656..562733a 100644
> --- a/drivers/gpu/drm/tilcdc/Makefile
> +++ b/drivers/gpu/drm/tilcdc/Makefile
> @@ -1,4 +1,7 @@
> -ccflags-y := -Iinclude/drm -Werror
> +ccflags-y := -Iinclude/drm
> +ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
> +       ccflags-y += -Werror
> +endif
>
>  tilcdc-y := \
>         tilcdc_crtc.o \
> --
> 1.7.7.6
Chen Gang March 12, 2013, 12:04 a.m. UTC | #2 
? 2013?03?11? 22:02, Rob Clark ??:
> On Sun, Mar 10, 2013 at 12:04 AM, Chen Gang <gang.chen@asianux.com> wrote:
>> >
>> >   When make with EXTRA_CFLAGS=-W, it will report error.
>> >   so give a check in Makefile.
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> > Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> 

  thanks.
diff mbox

Patch

diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile
index deda656..562733a 100644
--- a/drivers/gpu/drm/tilcdc/Makefile
+++ b/drivers/gpu/drm/tilcdc/Makefile
@@ -1,4 +1,7 @@ 
-ccflags-y := -Iinclude/drm -Werror
+ccflags-y := -Iinclude/drm
+ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
+	ccflags-y += -Werror
+endif
 
 tilcdc-y := \
 	tilcdc_crtc.o \