From patchwork Fri Jan 1 22:04:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7940101 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2A2389F387 for ; Fri, 1 Jan 2016 22:10:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5633A204DE for ; Fri, 1 Jan 2016 22:10:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 886BE20489 for ; Fri, 1 Jan 2016 22:10:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD4746E2B2; Fri, 1 Jan 2016 14:10:05 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 345 seconds by postgrey-1.34 at gabe; Fri, 01 Jan 2016 14:10:03 PST Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id C57886E2B2 for ; Fri, 1 Jan 2016 14:10:03 -0800 (PST) Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0MLgGJ-1aEqYZ1g5j-000pos; Fri, 01 Jan 2016 23:04:12 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Date: Fri, 01 Jan 2016 23:04:07 +0100 Message-ID: <5213510.IMdSbsXdoQ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <4194408.X82ccDjh5X@wuerfel> References: <4194408.X82ccDjh5X@wuerfel> MIME-Version: 1.0 X-Provags-ID: V03:K0:9sTAeplSWjU8hGiJSwze73q71GvRkLkazOX6XsSh4HsPST/Ise6 OGwcuzyj+/hSE2J/kFI5if4VZapj7pFmvyskpnZhk3ngaAS4KRs+YTrAD2Ow5G5US2jhQnL omdpkxWnWxIViLGhD+Ch4vriN70n7yZTnmVSWCM/H0OUTpEvHHfW9u6l9vKH4GS8PPNCg8j gbILBeI2RM6uZU9NDKv2A== X-UI-Out-Filterresults: notjunk:1; V01:K0:J6kkyJo28XY=:SmlQmbAmy2nAX8wKAFcZhQ qn/cO33gqeZ1zG/AdVgGGFZJRiSjyad8FDFWNpUPZ6ydlZYEUcy8WqGRWkPt/rQO0eCzSWVsn om8ELQh3BgPtSK4VWpDXi+2eLbTB3Huq5LB1vmLYfGVk2ubWthK6mKvRdEk2eWk9IcarYEsGM NwiOFhUj3A7LwbWKOKoU0P5hHRPb/4v/f5hOI+yAJEjCwZxf+yVkp+otA9zWBQ53nGj3RS0g4 KSkUINNhQlS3udwX/jgut2ewaXP7kkqa22mqmUp3z0Nfb+xPqNi2Dv5oAh3ImqmUwzYIUaAVk TSBNBLGBqU/A4Vx2ZZIepe7Y4dxD1cpSolITlVdXk/KFTOyRBGLX/Jh9Z8djWDJlQO9gzy9iM IVkYjxyxew4D3SqFDdmFO7+usdY5qSo7G43PKnAaLWv+cFHbEID5SJMs51VHYHM8lCfMNrck9 siFfoTwlH//uM0pCniUj24HsGIYkktBqNf9utSXq+wMeU/L1KQvp8Y58BzgnCgsFakrGF1yQy Y3WpBmZpwHgsPtdCZyDHHyocpCM24471AVShDgD0yurrVlXh9mQC9iRavmdHl4Xg2xCFK8I6f 28JSZr87iJ1AsxxUDrnsBTW5O0Agv2nYjnLfn8NuqtGXzMyc3U0wq+a19GYlpevE1RvdEFGHR 21PvGiQ00GBgJLWcd354XPcIGB0NdUAaV48XBPMATVstcEi2UM2Y4MQnorgGAr0c8uehAT6NK mDaoaCbCye/D3WrW Cc: Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP CONFIG_DRM_HDLCD is a tristate option that depends on the boolean CONFIG_DRM_ARM, which in turn depends on the tristate CONFIG_DRM. The effect of this is that a configuration with CONFIG_DRM=m and CONFIG_DRM_HDLCD=y can be chosen, but won't link because the DRM core symbols are not reachable from builtin code: drivers/built-in.o: In function `hdlcd_drm_unbind': drivers/gpu/drm/arm/hdlcd_drv.c:445: undefined reference to `drm_fbdev_cma_fini' drivers/gpu/drm/arm/hdlcd_drv.c:448: undefined reference to `drm_kms_helper_poll_fini' drivers/gpu/drm/arm/hdlcd_drv.c:450: undefined reference to `drm_vblank_cleanup' drivers/gpu/drm/arm/hdlcd_drv.c:452: undefined reference to `drm_irq_uninstall' drivers/gpu/drm/arm/hdlcd_drv.c:460: undefined reference to `drm_mode_config_cleanup' drivers/gpu/drm/arm/hdlcd_drv.c:461: undefined reference to `drm_dev_unregister' drivers/gpu/drm/arm/hdlcd_drv.c:462: undefined reference to `drm_dev_unref' ... This adds another dependency on CONFIG_DRM to enforce that DRM_HDLCD cannot be builtin if DRM is not. Signed-off-by: Arnd Bergmann --- Ok, I found yet another one after a few hundred extra randconfig builds on today's next. Let me know if you'd rather have the three Kconfig changes combined into a single patch, it's starting to get ridiculous. diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 81ea7802ca50..487fb1f0c979 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -7,7 +7,7 @@ config DRM_ARM config DRM_HDLCD tristate "ARM HDLCD" - depends on DRM_ARM + depends on DRM_ARM && DRM depends on COMMON_CLK select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER