From patchwork Sat Jun 27 21:20:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 6686541 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E71ECC05AC for ; Sun, 28 Jun 2015 17:10:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1A3F4205DB for ; Sun, 28 Jun 2015 17:10:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3452D205DA for ; Sun, 28 Jun 2015 17:10:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 747436E23F; Sun, 28 Jun 2015 10:10:44 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53A5D6E097 for ; Sat, 27 Jun 2015 14:21:04 -0700 (PDT) Received: from [192.168.1.2] ([77.182.50.16]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0LoHTx-1YboUz27y5-00gDIe; Sat, 27 Jun 2015 23:20:56 +0200 Message-ID: <558F13B5.6080602@users.sourceforge.net> Date: Sat, 27 Jun 2015 23:20:53 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Airlie , Hai Li , dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558F12BA.60709@users.sourceforge.net> In-Reply-To: <558F12BA.60709@users.sourceforge.net> X-Provags-ID: V03:K0:P7lSvF6+mzmonG6SEsey/B4D2LjzuQRTSuUDzMU2fbAbB6+0/nT xEW2/VWGKv3VYtMp7rvSHOyZaZmRd5sMfKndFzQR33DYrz3QmCFRGvTJ3ensd1Z1CcXKa2V +SBEGnwphD8vGSEoTBxMV6sgxhmgcpNuOZYiqhXGOifE56azWLCaknznaeSz8Lxcc9WKSug BWE5gN26141uRNjPYpcBQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:QKVAnuAcuOA=:kdkNhqCaHraopCu0TB9Xmd PSPfre4iACvJ6CtahSJNz8V/TJoi7u0HxRgISR/9xdVacokN2MUUJH/ZgRQfULqme38Ebp7RH iGnlrFBcQ/ZU+GRzViRM72YxodOcdWSJ8krlls7xQHvYYaAmhzl5kXN0RCtFlakEJM1c5nZ97 Cmdr22M1LcbdQlNmF8Qlgc/06YPvcRHVNo6yc36l/kTpcYIv24AfKH8gueLbGa9mJIRPIog/j DIPwJ9261/mTSuAfYB/UnOANsWfPxBcER2dLlwDtZoL/0ftfq43EF4nbhdHdAUZZKV3PercVW ssgVaTPx2A6qfzy0BceGPCqY5D+0lsr8pDiQupnwF4qPTOiyniFZV1YB7VlK1szO3I0LZiDS1 OEl9aMK/OvqzGWnpE6ZKX/JZoRlkD3iAnDL7LZCR/ShiVVJ/iLhdXYJCXnjtV2unAJ2vjAmB8 /oi9qDYdHgops/86p8BvSOim16qOp0nOKp4hjLTSM3SzYGqa3EjrSmE14KVs4I83LeIqoN1Fa WU2H/+155OXn6GJXaBGL6VpKrR8YLjZk7vimnHJYn+SNLszMLiiCYm2ybO62uW6/kcJV4ukDa O+miaTwuvPsWed13qB+qWH6jOFMXL6ZH0OQCll3/C4DOPDmr2wbtu9mKWeXvxhwjdJ0qTEK2j n738KW/YWTLmkxZLpA/1xjtleu7WSYF1KV5As3cSaJHutVYY9v0aDxx4mZXNfohxAKVc= X-Mailman-Approved-At: Sun, 28 Jun 2015 10:10:39 -0700 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 27 Jun 2015 22:05:31 +0200 The dsi_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/msm/dsi/dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 1f2561e..dc4f38f 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev) return msm_dsi; fail: - if (msm_dsi) - dsi_destroy(msm_dsi); - + dsi_destroy(msm_dsi); return ERR_PTR(ret); }