From patchwork Thu Dec 3 13:05:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 7759801 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EA9D19F39B for ; Thu, 3 Dec 2015 13:05:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 039A320574 for ; Thu, 3 Dec 2015 13:05:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B59E7205B3 for ; Thu, 3 Dec 2015 13:05:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 00CD56EC06; Thu, 3 Dec 2015 05:05:56 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lists.s-osg.org (lists.s-osg.org [54.187.51.154]) by gabe.freedesktop.org (Postfix) with ESMTP id 307676EC06 for ; Thu, 3 Dec 2015 05:05:55 -0800 (PST) Received: from [10.203.15.114] (unknown [200.3.249.195]) by lists.s-osg.org (Postfix) with ESMTPSA id 102C2462A3; Thu, 3 Dec 2015 05:05:51 -0800 (PST) Subject: Re: [PATCH v2 1/2] drm/exynos: dp: add of_graph dt binding support for panel To: Inki Dae , dri-devel@lists.freedesktop.org References: <1449057472-4389-1-git-send-email-inki.dae@samsung.com> <565F0871.6080109@osg.samsung.com> <565FA4C8.4080502@samsung.com> From: Javier Martinez Canillas Message-ID: <56603E2C.2090005@osg.samsung.com> Date: Thu, 3 Dec 2015 10:05:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <565FA4C8.4080502@samsung.com> Cc: linux-samsung-soc@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Inki, On 12/02/2015 11:11 PM, Inki Dae wrote: > Hi Javier, > > 2015? 12? 03? 00:04? Javier Martinez Canillas ?(?) ? ?: >> Hello Inki, >> >> On 12/02/2015 08:57 AM, Inki Dae wrote: >>> This patch adds of_graph dt binding support for panel device >>> and also keeps the backward compatibility. >>> >> >> You have to also update the DT binding doc which seems to be >> outdated already: >> >> Documentation/devicetree/bindings/display/exynos/exynos_dp.txt > > Right. It should be updated. > Great, I see you already posted that. >> >>> i.e., >>> The dts file for Exynos5800 based peach pi board >>> has a panel property so we need to keep the backward compatibility. >>> >> >> How did you test this patch? > > I thought you will test it and give me tested-by because you commented like below, > " Assuming you can make a distinction if the endpoint is a panel or a bridge, > then yes, I agree with the idea of the patch. Please feel free to cc me if > you post such a patch and I'll gladly test it on my Exynos5800 Peach Pi." > > That is why I cced you. I really have no any Exynos5800 Peach Pi board. > Yes, but if you didn't test a patch, then it should be marked with a RFT prefix in the subject line or at least mention that needs testing since you lack the HW to test. I've no way to know if you have another board with a similar design :) But what I meant is how the patch is supposed to be tested since there ins't a change in the Exynos5800 Peach Pi DTS? We can of course test that doesn't break backward compatibility but we don't have a way to test the actual change. So I tested with the patch following patch [0] and things are working correctly. Please include that patch in your series. I've some comments on your patch though but I'll comment on your lastest version. > Thanks, > Inki Dae > >> >> Best regards, >> Best regards, diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 7b018e451880..9c6fd7314ee0 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -122,6 +122,12 @@ compatible = "auo,b133htn01"; power-supply = <&tps65090_fet6>; backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&dp_out>; + }; + }; }; mmc1_pwrseq: mmc1_pwrseq { @@ -148,7 +154,14 @@ samsung,link-rate = <0x0a>; samsung,lane-count = <2>; samsung,hpd-gpio = <&gpx2 6 GPIO_ACTIVE_HIGH>; - panel = <&panel>; + + ports { + port@0 { + dp_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; }; &fimd {