| Message ID | 5cda6ee2.1c69fb81.2949b.d3e7@mx.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: Remove duplicate header | expand |
On Tue, May 14, 2019 at 1:05 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Sabyasachi, > > Thank you for the patch. > > On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote: > > Remove drm/drm_panel.h which is included more than once > > > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > > --- > > drivers/gpu/drm/bridge/panel.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > index 7cbaba2..402b318 100644 > > --- a/drivers/gpu/drm/bridge/panel.c > > +++ b/drivers/gpu/drm/bridge/panel.c > > @@ -15,7 +15,6 @@ > > #include <drm/drm_crtc_helper.h> > > #include <drm/drm_encoder.h> > > #include <drm/drm_modeset_helper_vtables.h> > > -#include <drm/drm_panel.h> > > Which tree is this against ? The patch applies on neither drm-next nor > drm-misc-next. > It is against linux-next tree > While at it, could you you reorder the other header alphabetically to > make this kind of issue easier to notice ? > It is already arranged in alphabetical order > > > > struct panel_bridge { > > struct drm_bridge bridge; > > -- > Regards, > > Laurent Pinchart
Hi Sabyasachi, On Thu, May 16, 2019 at 06:45:04PM +0530, Sabyasachi Gupta wrote: > On Tue, May 14, 2019 at 1:05 PM Laurent Pinchart wrote: > > On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote: > > > Remove drm/drm_panel.h which is included more than once > > > > > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > > > --- > > > drivers/gpu/drm/bridge/panel.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > > index 7cbaba2..402b318 100644 > > > --- a/drivers/gpu/drm/bridge/panel.c > > > +++ b/drivers/gpu/drm/bridge/panel.c > > > @@ -15,7 +15,6 @@ > > > #include <drm/drm_crtc_helper.h> > > > #include <drm/drm_encoder.h> > > > #include <drm/drm_modeset_helper_vtables.h> > > > -#include <drm/drm_panel.h> > > > > Which tree is this against ? The patch applies on neither drm-next nor > > drm-misc-next. > > > > It is against linux-next tree You will likely have to rebase it on top of the drm-next or drm-next-misc branch. > > While at it, could you you reorder the other header alphabetically to > > make this kind of issue easier to notice ? > > It is already arranged in alphabetical order There's an #include <drm/drm_panel.h> at the top of the list of includes. That's the one that is out of place. > > > > > > struct panel_bridge { > > > struct drm_bridge bridge;
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 7cbaba2..402b318 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -15,7 +15,6 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h> struct panel_bridge { struct drm_bridge bridge;
Remove drm/drm_panel.h which is included more than once Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> --- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)