| Message ID | 632b3b11118969ff6fccb8a2f606c87fde41c138.1603469755.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
Am 23.10.20 um 18:32 schrieb Mauro Carvalho Chehab: > A kernel-doc markup can't be mixed with a random comment, > as it causes parsing problems. > > While here, change an invalid kernel-doc markup into > a common comment. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Acked-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index f8785bdec79c..1d4b54950528 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -239,9 +239,11 @@ bool amdgpu_device_supports_baco(struct drm_device *dev) > return amdgpu_asic_supports_baco(adev); > } > > +/* > + * VRAM access helper functions > + */ > + > /** > - * VRAM access helper functions. > - * > * amdgpu_device_vram_access - read/write a buffer in vram > * > * @adev: amdgpu_device pointer > @@ -4497,7 +4499,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev, > bool need_emergency_restart = false; > bool audio_suspended = false; > > - /** > + /* > * Special case: RAS triggered and full reset isn't supported > */ > need_emergency_restart = amdgpu_ras_need_emergency_restart(adev);
Applied. Thanks! Alex On Fri, Oct 23, 2020 at 12:38 PM Christian König <christian.koenig@amd.com> wrote: > > Am 23.10.20 um 18:32 schrieb Mauro Carvalho Chehab: > > A kernel-doc markup can't be mixed with a random comment, > > as it causes parsing problems. > > > > While here, change an invalid kernel-doc markup into > > a common comment. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > Acked-by: Christian König <christian.koenig@amd.com> > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > index f8785bdec79c..1d4b54950528 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > > @@ -239,9 +239,11 @@ bool amdgpu_device_supports_baco(struct drm_device *dev) > > return amdgpu_asic_supports_baco(adev); > > } > > > > +/* > > + * VRAM access helper functions > > + */ > > + > > /** > > - * VRAM access helper functions. > > - * > > * amdgpu_device_vram_access - read/write a buffer in vram > > * > > * @adev: amdgpu_device pointer > > @@ -4497,7 +4499,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev, > > bool need_emergency_restart = false; > > bool audio_suspended = false; > > > > - /** > > + /* > > * Special case: RAS triggered and full reset isn't supported > > */ > > need_emergency_restart = amdgpu_ras_need_emergency_restart(adev); > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f8785bdec79c..1d4b54950528 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -239,9 +239,11 @@ bool amdgpu_device_supports_baco(struct drm_device *dev) return amdgpu_asic_supports_baco(adev); } +/* + * VRAM access helper functions + */ + /** - * VRAM access helper functions. - * * amdgpu_device_vram_access - read/write a buffer in vram * * @adev: amdgpu_device pointer @@ -4497,7 +4499,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev, bool need_emergency_restart = false; bool audio_suspended = false; - /** + /* * Special case: RAS triggered and full reset isn't supported */ need_emergency_restart = amdgpu_ras_need_emergency_restart(adev);
A kernel-doc markup can't be mixed with a random comment, as it causes parsing problems. While here, change an invalid kernel-doc markup into a common comment. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)