From patchwork Wed Aug 15 09:32:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jani Nikula X-Patchwork-Id: 1325451 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 039D2DFFED for ; Wed, 15 Aug 2012 12:28:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D8D86A0C1C for ; Wed, 15 Aug 2012 05:28:29 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 927B5A0D93 for ; Wed, 15 Aug 2012 02:33:15 -0700 (PDT) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 15 Aug 2012 02:33:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,772,1336374000"; d="scan'208";a="181277043" Received: from unknown (HELO localhost) ([10.255.12.250]) by azsmga001.ch.intel.com with ESMTP; 15 Aug 2012 02:32:48 -0700 From: Jani Nikula To: dri-devel@lists.freedesktop.org, linux@arm.linux.org.uk, daniel@ffwll.ch, airlied@linux.ie Subject: [PATCH 1/4] drm/i915: fix EDID memory leak in SDVO Date: Wed, 15 Aug 2012 12:32:36 +0300 Message-Id: <738a7ab23d49f3fb68cc67062eaa57ed6c8d23c7.1345022231.git.jani.nikula@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: References: In-Reply-To: References: X-Mailman-Approved-At: Wed, 15 Aug 2012 05:25:40 -0700 Cc: jani.nikula@intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org The EDID returned by drm_get_edid() was never freed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_sdvo.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index d172e98..d81bb0b 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c @@ -1692,6 +1692,7 @@ static bool intel_sdvo_detect_hdmi_audio(struct drm_connector *connector) edid = intel_sdvo_get_edid(connector); if (edid != NULL && edid->input & DRM_EDID_INPUT_DIGITAL) has_audio = drm_detect_monitor_audio(edid); + kfree(edid); return has_audio; }