From patchwork Tue May 19 21:05:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 6440561 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BC8159F1CC for ; Tue, 19 May 2015 21:06:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF1F120279 for ; Tue, 19 May 2015 21:06:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id CB5D420274 for ; Tue, 19 May 2015 21:06:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D20C6E2A6; Tue, 19 May 2015 14:06:13 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 000946E2A6 for ; Tue, 19 May 2015 14:06:11 -0700 (PDT) Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0MY6Nc-1YhfYy2T4K-00UtTc; Tue, 19 May 2015 23:05:56 +0200 From: Arnd Bergmann To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: remove unused function 'drm_property_unreference_blob_locked' Date: Tue, 19 May 2015 23:05:53 +0200 Message-ID: <7933590.26epboaQAP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:aeVK3jiOtTN7oMOLvCH2qPamqJMXx9UwGMTs7Ky0hA7fv7mL2bw 0V5+nihqd/DV5MCSI8f4N12Yd1HyyDFpwNfmHmKSjIysPHBAltcH6VLLydunG2gGSR0qyaJ Tjg5OK1xpbVkqHKnL6M/4fHa36BrOc9a3uLOfFInbAGDnZExfjPplT7WqnJQjOnJkrExt96 A1qzCBqewJVY0acoG/H6A== X-UI-Out-Filterresults: notjunk:1; Cc: Daniel Vetter , Daniel Stone X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This function was added recently but never used, and causes a compile warning: drivers/gpu/drm/drm_crtc.c:4324:13: warning: 'drm_property_unreference_blob_locked' defined but not used [-Wunused-function] Removing that function avoids the warning. It can simply be put back in case it is needed in the future. Signed-off-by: Arnd Bergmann Fixes: 6bcacf51d05 ("drm: Add reference counting to blob properties") --- The broken patch is currently in git://anongit.freedesktop.org/drm-intel#topic/drm-misc diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4059f065c854..6e60f71bbf46 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob) EXPORT_SYMBOL(drm_property_unreference_blob); /** - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held - * - * Drop a reference on a blob property. May free the object. This must be - * called with blob_lock held. - * - * @param dev Device the blob was created on - * @param blob Pointer to blob property - */ -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob) -{ - if (!blob) - return; - - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount)); - - kref_put(&blob->refcount, drm_property_free_blob); -} - -/** * drm_property_reference_blob - Take a reference on an existing property * * Take a new reference on an existing blob property.