From patchwork Tue Jan 16 10:35:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Meghana Madhyastha X-Patchwork-Id: 10166421 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 895CB601E7 for ; Tue, 16 Jan 2018 10:35:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71AA32842D for ; Tue, 16 Jan 2018 10:35:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 647BD28462; Tue, 16 Jan 2018 10:35:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D127D2842D for ; Tue, 16 Jan 2018 10:35:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 12D216E1D3; Tue, 16 Jan 2018 10:35:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B41D6E1D3 for ; Tue, 16 Jan 2018 10:35:23 +0000 (UTC) Received: by mail-it0-x241.google.com with SMTP id p139so4338358itb.1 for ; Tue, 16 Jan 2018 02:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lwtKriSJ0+SMVh44Axm5ctXMKQ+Tp+GEnZwAt4gyx/Y=; b=i5Cl6cou3LxJyfQCPlhuKTxkD1IQVlZgLdvx/8GntJiQZaadDLl+3zMidbGTZ9ibVH 7W/cYaxpMBlbAes+o57QB69oIq8VJvgyz3up3JANipSizfdr6OMF/HZO4lvNQDpVsQMb oLYh1RlvcKV8y2WmAj20S6XW3FIbBzR62CPwIGmHE79a7fUUBcY6AjVAH5y+9Wr96keZ sUMLgTjfD1i8OuV6VjWBjzYvV5T54ycrCQk6xIMENgNYM5bPjYzqC9sYoSqcl9gbYSZ/ btApVbiNUcV1OUpICjZKs9TWVSH2M0zzCcCqo1T9PsHm+hzCYK81ZaOd83zu2vkUQ7XY yp2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lwtKriSJ0+SMVh44Axm5ctXMKQ+Tp+GEnZwAt4gyx/Y=; b=qJL81lv1EAUuyBUHRJBgbjw71wRGqW+7H1NP2Ov9Bs3IjQtXaAH+p5fM4/SrAKwNIT jW+Rlt8HQIhGX2lOXTIHzTdDkgeCThR5OFQz4xMAGU4GsEJL0w/0S/MY4ZlO4tTKk8HP o23nny5FCP5QaZaNaOGmOiv2Nx6Dlswx7rOZzul0pBSSK2hVO1iZd59xIvAGy0OOKiBL M4wvL5bxXsDjWUGgRs1DMTkEQ7i/cXIh0VZsgs1afARWtMX6xZsLRTWDbogQnvUBSwNK 0FqKR2agfNBrUnDSeDMX1tOaCQl4SCf39dYgCpTfxE5cyVEltdZF/710Yj0p4JyCVYvc U4HQ== X-Gm-Message-State: AKwxytf6E22DqX9XfMlLbcIr72uBAdVl1cOzalJ6D8HNTvEmHaYN9acs AkcUMQv4AMJuwzC1utc8C44= X-Google-Smtp-Source: ACJfBou9Zb7lTGnyZMG58g+hjNgZnK0lWZcfG3iax1v0NOg/7RhLIb/GCBFwpHds1Bss+N+1NMD1oA== X-Received: by 10.36.29.81 with SMTP id 78mr4486804itj.53.1516098922352; Tue, 16 Jan 2018 02:35:22 -0800 (PST) Received: from raspberrypi ([122.171.87.79]) by smtp.gmail.com with ESMTPSA id v190sm1042222itb.3.2018.01.16.02.35.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 02:35:21 -0800 (PST) Date: Tue, 16 Jan 2018 10:35:15 +0000 From: Meghana Madhyastha To: Lee Jones , Daniel Thompson , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers Message-ID: <7ade4e0607f04902d6a9cacbe89fea1e99665205.1516098341.git.meghana.madhyastha@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 6 ++---- drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 6 ++---- drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 12 ++++-------- drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 12 ++++-------- 4 files changed, 12 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index 6ba93449f..4c1b29eec 100644 --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c @@ -45,8 +45,7 @@ static int innolux_panel_disable(struct drm_panel *panel) if (!innolux->enabled) return 0; - innolux->backlight->props.power = FB_BLANK_POWERDOWN; - backlight_update_status(innolux->backlight); + backlight_disable(innolux->backlight); err = mipi_dsi_dcs_set_display_off(innolux->link); if (err < 0) @@ -151,8 +150,7 @@ static int innolux_panel_enable(struct drm_panel *panel) if (innolux->enabled) return 0; - innolux->backlight->props.power = FB_BLANK_UNBLANK; - ret = backlight_update_status(innolux->backlight); + ret = backlight_enable(innolux->backlight); if (ret) { DRM_DEV_ERROR(panel->drm->dev, "Failed to enable backlight %d\n", ret); diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index 5b2340ef7..0a94ab79a 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -192,8 +192,7 @@ static int jdi_panel_disable(struct drm_panel *panel) if (!jdi->enabled) return 0; - jdi->backlight->props.power = FB_BLANK_POWERDOWN; - backlight_update_status(jdi->backlight); + backlight_disable(jdi->backlight); jdi->enabled = false; @@ -289,8 +288,7 @@ static int jdi_panel_enable(struct drm_panel *panel) if (jdi->enabled) return 0; - jdi->backlight->props.power = FB_BLANK_UNBLANK; - backlight_update_status(jdi->backlight); + backlight_enable(jdi->backlight); jdi->enabled = true; diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c index 3cce3ca19..1512ec4f3 100644 --- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c +++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c @@ -96,10 +96,8 @@ static int sharp_panel_disable(struct drm_panel *panel) if (!sharp->enabled) return 0; - if (sharp->backlight) { - sharp->backlight->props.power = FB_BLANK_POWERDOWN; - backlight_update_status(sharp->backlight); - } + if (sharp->backlight) + backlight_disable(sharp->backlight); sharp->enabled = false; @@ -263,10 +261,8 @@ static int sharp_panel_enable(struct drm_panel *panel) if (sharp->enabled) return 0; - if (sharp->backlight) { - sharp->backlight->props.power = FB_BLANK_UNBLANK; - backlight_update_status(sharp->backlight); - } + if (sharp->backlight) + backlight_enable(sharp->backlight); sharp->enabled = true; diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c index 3aeb0bda4..a6af3257f 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c @@ -117,10 +117,8 @@ static int sharp_nt_panel_disable(struct drm_panel *panel) if (!sharp_nt->enabled) return 0; - if (sharp_nt->backlight) { - sharp_nt->backlight->props.power = FB_BLANK_POWERDOWN; - backlight_update_status(sharp_nt->backlight); - } + if (sharp_nt->backlight) + backlight_disable(sharp_nt->backlight); sharp_nt->enabled = false; @@ -203,10 +201,8 @@ static int sharp_nt_panel_enable(struct drm_panel *panel) if (sharp_nt->enabled) return 0; - if (sharp_nt->backlight) { - sharp_nt->backlight->props.power = FB_BLANK_UNBLANK; - backlight_update_status(sharp_nt->backlight); - } + if (sharp_nt->backlight) + backlight_enable(sharp_nt->backlight); sharp_nt->enabled = true;