| Message ID | 7c2182b365c5b0a574744a2832e0209aa1fc009e.1689169087.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/gem-fb-helper: Consistenly use drm_dbg_kms() | expand |
Hi Am 12.07.23 um 15:42 schrieb Geert Uytterhoeven: > All debug messages in drm_gem_framebuffer_helper.c use drm_dbg_kms(), > except for one, which uses drm_dbg(). > Replace the outlier by drm_dbg_kms() to restore consistency. > > Fixes: c91acda3a380bcaf ("drm/gem: Check for valid formats") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Thanks. IIRC drm_dbg() is for drivers. Best regards Thomas > --- > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c > index b8a615a138cd675f..3bdb6ba37ff42fb6 100644 > --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c > +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c > @@ -168,8 +168,8 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, > if (drm_drv_uses_atomic_modeset(dev) && > !drm_any_plane_has_format(dev, mode_cmd->pixel_format, > mode_cmd->modifier[0])) { > - drm_dbg(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", > - &mode_cmd->pixel_format, mode_cmd->modifier[0]); > + drm_dbg_kms(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", > + &mode_cmd->pixel_format, mode_cmd->modifier[0]); > return -EINVAL; > } >
On 7/12/23 10:42, Geert Uytterhoeven wrote: > All debug messages in drm_gem_framebuffer_helper.c use drm_dbg_kms(), > except for one, which uses drm_dbg(). > Replace the outlier by drm_dbg_kms() to restore consistency. > > Fixes: c91acda3a380bcaf ("drm/gem: Check for valid formats") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Maíra Canal <mcanal@igalia.com> Thanks for sending this fix! Best Regards, - Maíra > --- > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c > index b8a615a138cd675f..3bdb6ba37ff42fb6 100644 > --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c > +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c > @@ -168,8 +168,8 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, > if (drm_drv_uses_atomic_modeset(dev) && > !drm_any_plane_has_format(dev, mode_cmd->pixel_format, > mode_cmd->modifier[0])) { > - drm_dbg(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", > - &mode_cmd->pixel_format, mode_cmd->modifier[0]); > + drm_dbg_kms(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", > + &mode_cmd->pixel_format, mode_cmd->modifier[0]); > return -EINVAL; > } >
diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index b8a615a138cd675f..3bdb6ba37ff42fb6 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -168,8 +168,8 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, if (drm_drv_uses_atomic_modeset(dev) && !drm_any_plane_has_format(dev, mode_cmd->pixel_format, mode_cmd->modifier[0])) { - drm_dbg(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", - &mode_cmd->pixel_format, mode_cmd->modifier[0]); + drm_dbg_kms(dev, "Unsupported pixel format %p4cc / modifier 0x%llx\n", + &mode_cmd->pixel_format, mode_cmd->modifier[0]); return -EINVAL; }
All debug messages in drm_gem_framebuffer_helper.c use drm_dbg_kms(), except for one, which uses drm_dbg(). Replace the outlier by drm_dbg_kms() to restore consistency. Fixes: c91acda3a380bcaf ("drm/gem: Check for valid formats") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)