diff mbox series

[1/2] drm/panel-simple: add support for NEC NL10276BC13-01C panel

Message ID 842736c513b948ee00fdcbe30df3a5a6d0eed9f0.1589226066.git.approximatenumber@gmail.com (mailing list archive)
State New, archived
Headers show
Series Add support for NEC NL10276BC13-01C panel | expand

Commit Message

Maksim Melnikov May 11, 2020, 8:29 p.m. UTC
The NL10276BC13-01C is a 6.5" 1024x768 XGA TFT LCD panel with LVDS interface. It is used for industrial purposes in devices such as HMI.

Signed-off-by: Maksim Melnikov <approximatenumber@gmail.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Comments

Sam Ravnborg June 29, 2020, 8:04 a.m. UTC | #1
On Mon, May 11, 2020 at 11:29:24PM +0300, Maksim Melnikov wrote:
> The NL10276BC13-01C is a 6.5" 1024x768 XGA TFT LCD panel with LVDS interface. It is used for industrial purposes in devices such as HMI.
> 
> Signed-off-by: Maksim Melnikov <approximatenumber@gmail.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3ad828eae..7ded13157 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2372,6 +2372,31 @@ static const struct panel_desc nec_nl4827hc19_05b = {
>  	.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
>  };
>  
> +static const struct display_timing nec_nl10276bc13_01c_timing = {
> +	.pixelclock = { 62600000, 68200000, 78100000 },
> +	.hactive = { 1024, 1024, 1024 },
> +	.hfront_porch = { 15, 64, 159 },
> +	.hback_porch = { 5, 5, 5 },
> +	.hsync_len = { 1, 1, 256 },
> +	.vactive = { 768, 768, 768 },
> +	.vfront_porch = { 3, 40, 99 },
> +	.vback_porch = { 2, 2, 2 },
> +	.vsync_len = { 1, 1, 128 },
> +	.flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc nec_nl10276bc13_01c = {
> +	.timings = &nec_nl10276bc13_01c_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 132,
> +		.height = 99,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
Sorry for getting back so late.

Please include .bus_flags too.
We want the description to be complete.

	Sam
> +};
> +
>  static const struct drm_display_mode netron_dy_e231732_mode = {
>  	.clock = 66000,
>  	.hdisplay = 1024,
> @@ -3634,6 +3659,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "nec,nl4827hc19-05b",
>  		.data = &nec_nl4827hc19_05b,
> +	}, {
> +		.compatible = "nec,nl10276bc13_01c",
> +		.data = &nec_nl10276bc13_01c,
>  	}, {
>  		.compatible = "netron-dy,e231732",
>  		.data = &netron_dy_e231732,
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3ad828eae..7ded13157 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2372,6 +2372,31 @@  static const struct panel_desc nec_nl4827hc19_05b = {
 	.bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };
 
+static const struct display_timing nec_nl10276bc13_01c_timing = {
+	.pixelclock = { 62600000, 68200000, 78100000 },
+	.hactive = { 1024, 1024, 1024 },
+	.hfront_porch = { 15, 64, 159 },
+	.hback_porch = { 5, 5, 5 },
+	.hsync_len = { 1, 1, 256 },
+	.vactive = { 768, 768, 768 },
+	.vfront_porch = { 3, 40, 99 },
+	.vback_porch = { 2, 2, 2 },
+	.vsync_len = { 1, 1, 128 },
+	.flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc nec_nl10276bc13_01c = {
+	.timings = &nec_nl10276bc13_01c_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 132,
+		.height = 99,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode netron_dy_e231732_mode = {
 	.clock = 66000,
 	.hdisplay = 1024,
@@ -3634,6 +3659,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "nec,nl4827hc19-05b",
 		.data = &nec_nl4827hc19_05b,
+	}, {
+		.compatible = "nec,nl10276bc13_01c",
+		.data = &nec_nl10276bc13_01c,
 	}, {
 		.compatible = "netron-dy,e231732",
 		.data = &netron_dy_e231732,