From patchwork Wed Dec 11 00:37:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chubb X-Patchwork-Id: 3322401 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F1FA5C0D4A for ; Wed, 11 Dec 2013 06:24:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 373942072E for ; Wed, 11 Dec 2013 06:24:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id ED38120729 for ; Wed, 11 Dec 2013 06:24:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89057FAB71; Tue, 10 Dec 2013 22:23:54 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org X-Greylist: delayed 1648 seconds by postgrey-1.32 at gabe; Tue, 10 Dec 2013 17:04:55 PST Received: from lemon.ertos.nicta.com.au (lemon.ertos.nicta.com.au [203.143.174.143]) by gabe.freedesktop.org (Postfix) with ESMTP id 5746DFAC1C for ; Tue, 10 Dec 2013 17:04:55 -0800 (PST) Received: from [2001:388:d000:800:224:d7ff:feaf:390] (port=52119 helo=Diprotodon.chubb.wattle.id.au) by lemon.ertos.nicta.com.au with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1VqXm4-0000cB-GM; Wed, 11 Dec 2013 11:35:38 +1100 Date: Wed, 11 Dec 2013 11:37:05 +1100 Message-ID: <84mwk86x5a.wl%peter.chubb@nicta.com.au> From: Peter Chubb To: markus@trippelsdorf.de, User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/23.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Face: GgFg(Z>fx((4\32hvXq<)|jndSniCH~~$D)Ka:P@e@JR1P%Vr}EwUdfwf-4j\rUs#JR{'h# !]])6%Jh~b$VA|ALhnpPiHu[-x~@<"@Iv&|%R)Fq[[, (&Z'O)Q)xCqe1\M[F8#9l8~}#u$S$Rm`S9% \'T@`:&8>Sb*c5d'=eDYI&GF`+t[LfDH="MP5rwOO]w>ALi7'=QJHz&y&C&TE_3j! Organization: NICTA MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 2001:388:d000:800:224:d7ff:feaf:390 X-SA-Exim-Mail-From: peter.chubb@nicta.com.au X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Subject: Can no longer shutdown after drm/radeon: Implement radeon_pci_shutdown X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:56:45 +0000) X-SA-Exim-Scanned: Yes (on lemon.ertos.nicta.com.au) X-Mailman-Approved-At: Tue, 10 Dec 2013 22:23:44 -0800 Cc: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Virus-Scanned: ClamAV using ClamSMTP On my HP Elitebook 8740w qith a Mobility Radeon HD 5870 commit 846ae41ae99d314bf2a02784152208a6ddf7eddc breaks shutdown. The machine hangs when trying to shutdown, kexec or hibernate, before seeing the usual `machine halted' (or whatever) message. If I comment out thus: index 9f5ff28..40bff3c 100644 --- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -514,7 +514,7 @@ radeon_pci_shutdown(struct pci_dev *pdev) { struct drm_device *dev = pci_get_drvdata(pdev); - radeon_driver_unload_kms(dev); + /*radeon_driver_unload_kms(dev);*/ } then everything works again. Thsi is obviously not the proper fix.