| Message ID | 87lgodez3z.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Morimoto-san, Thank you for the patch. On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Now, we can use of_graph_get_remote_endpoint(). Let's use it. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > based on 4c9c3d595f1bad021cc126d20879df4016801736 > ("of_graph: add of_graph_get_remote_endpoint()") This commit isn't upstream yet. I've taken the patch in my tree and will rebase it on top of v4.13-rc1 before submitting it for v4.14. > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 82b978a..66d8cc3 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -309,7 +309,7 @@ static int rcar_du_encoders_init_one(struct > rcar_du_device *rcdu, return -ENODEV; > } > > - entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0); > + entity_ep_node = of_graph_get_remote_endpoint(ep->local_node); > > for_each_endpoint_of_node(entity, ep_node) { > if (ep_node == entity_ep_node)
Hi Laurent, On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote: >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> Now, we can use of_graph_get_remote_endpoint(). Let's use it. >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> --- >> based on 4c9c3d595f1bad021cc126d20879df4016801736 >> ("of_graph: add of_graph_get_remote_endpoint()") > > This commit isn't upstream yet. I've taken the patch in my tree and will FTR, it is in linux-next, but the function has been moved from drivers/of/base.c to drivers/of/property.c. > rebase it on top of v4.13-rc1 before submitting it for v4.14. Note that a simple rebase won't make it disappear, due to the move. So you'll have to drop it explicitly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Thursday 29 Jun 2017 13:22:14 Geert Uytterhoeven wrote: > On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart wrote: > > On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote: > >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > >> Now, we can use of_graph_get_remote_endpoint(). Let's use it. > >> > >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > >> --- > >> based on 4c9c3d595f1bad021cc126d20879df4016801736 > >> ("of_graph: add of_graph_get_remote_endpoint()") > > > > This commit isn't upstream yet. I've taken the patch in my tree and will > > FTR, it is in linux-next, but the function has been moved from > drivers/of/base.c to drivers/of/property.c. Yes, I've seen the patch in linux-next. > > rebase it on top of v4.13-rc1 before submitting it for v4.14. > > Note that a simple rebase won't make it disappear, due to the move. > So you'll have to drop it explicitly. I'm not sure to follow you. This is a driver patch, depending on a function that will make it to v4.13-rc1. At this time it thus doesn't compile against mainline. I'll rebase it on top of v4.13-rc1, the dependency will be there, and I'll submit it for v4.14.
Hi Laurent, On Thu, Jun 29, 2017 at 1:26 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thursday 29 Jun 2017 13:22:14 Geert Uytterhoeven wrote: >> On Thu, Jun 29, 2017 at 12:44 PM, Laurent Pinchart wrote: >> > On Wednesday 28 Jun 2017 00:32:17 Kuninori Morimoto wrote: >> >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> >> >> Now, we can use of_graph_get_remote_endpoint(). Let's use it. >> >> >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> > >> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> > >> >> --- >> >> based on 4c9c3d595f1bad021cc126d20879df4016801736 >> >> ("of_graph: add of_graph_get_remote_endpoint()") >> > >> > This commit isn't upstream yet. I've taken the patch in my tree and will >> >> FTR, it is in linux-next, but the function has been moved from >> drivers/of/base.c to drivers/of/property.c. > > Yes, I've seen the patch in linux-next. > >> > rebase it on top of v4.13-rc1 before submitting it for v4.14. >> >> Note that a simple rebase won't make it disappear, due to the move. >> So you'll have to drop it explicitly. > > I'm not sure to follow you. This is a driver patch, depending on a function > that will make it to v4.13-rc1. At this time it thus doesn't compile against > mainline. I'll rebase it on top of v4.13-rc1, the dependency will be there, > and I'll submit it for v4.14. Sorry, I misunderstood you were going to take "of_graph: add of_graph_get_remote_endpoint()" in your tree as a dependency. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 82b978a..66d8cc3 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c @@ -309,7 +309,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, return -ENODEV; } - entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0); + entity_ep_node = of_graph_get_remote_endpoint(ep->local_node); for_each_endpoint_of_node(entity, ep_node) { if (ep_node == entity_ep_node)