| Message ID | 8b7f10d6373e117cc26487e1c6963e637bc01dee.1622095610.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm/kmb: Fix an error handling path | expand |
This is already fixed in the patch from Zhen Lei. > -----Original Message----- > From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Sent: Wednesday, May 26, 2021 11:10 PM > To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>; Dea, Edmund J > <edmund.j.dea@intel.com>; airlied@linux.ie; daniel@ffwll.ch; > sam@ravnborg.org > Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; kernel- > janitors@vger.kernel.org; Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Subject: [PATCH v2 2/2] drm/kmb: Do not report 0 (success) in case of error > > 'ret' is known to be 0 at this point. > Reporting the error from the previous 'platform_get_irq()' call is likely, > so add the missing assignment. > > Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > v2: New patch > --- > drivers/gpu/drm/kmb/kmb_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/kmb/kmb_drv.c > b/drivers/gpu/drm/kmb/kmb_drv.c > index fa28e42da460..d9e10ac9847c 100644 > --- a/drivers/gpu/drm/kmb/kmb_drv.c > +++ b/drivers/gpu/drm/kmb/kmb_drv.c > @@ -138,6 +138,7 @@ static int kmb_hw_init(struct drm_device *drm, > unsigned long flags) > irq_lcd = platform_get_irq(pdev, 0); > if (irq_lcd < 0) { > drm_err(&kmb->drm, "irq_lcd not found"); > + ret = irq_lcd; > goto setup_fail; > } > > -- > 2.30.2
diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index fa28e42da460..d9e10ac9847c 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -138,6 +138,7 @@ static int kmb_hw_init(struct drm_device *drm, unsigned long flags) irq_lcd = platform_get_irq(pdev, 0); if (irq_lcd < 0) { drm_err(&kmb->drm, "irq_lcd not found"); + ret = irq_lcd; goto setup_fail; }
'ret' is known to be 0 at this point. Reporting the error from the previous 'platform_get_irq()' call is likely, so add the missing assignment. Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- v2: New patch --- drivers/gpu/drm/kmb/kmb_drv.c | 1 + 1 file changed, 1 insertion(+)