From patchwork Thu Feb 8 14:38:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10207229 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D30D602D8 for ; Thu, 8 Feb 2018 14:38:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5ED9D294B9 for ; Thu, 8 Feb 2018 14:38:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 527E1294F9; Thu, 8 Feb 2018 14:38:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B929E294B9 for ; Thu, 8 Feb 2018 14:38:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EF786E63B; Thu, 8 Feb 2018 14:38:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.15.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00CF86E63B for ; Thu, 8 Feb 2018 14:38:45 +0000 (UTC) Received: from [192.168.1.2] ([78.49.237.151]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MbhSP-1eRJ7m2ETN-00J1kq; Thu, 08 Feb 2018 15:38:43 +0100 Subject: [PATCH 2/3] drm/gma500: Improve four size determinations From: SF Markus Elfring To: dri-devel@lists.freedesktop.org, David Airlie , Patrik Jakobsson References: <079c31b2-a2e6-cf42-cecb-e1e10dd241f6@users.sourceforge.net> Message-ID: <9165671d-8a07-30e7-c0ee-936e91331297@users.sourceforge.net> Date: Thu, 8 Feb 2018 15:38:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <079c31b2-a2e6-cf42-cecb-e1e10dd241f6@users.sourceforge.net> Content-Language: en-US X-Provags-ID: V03:K0:a8Tdv8hgQUOvzTfyPOZPjtUfzNHgqhBiIjXzSsLtD9w6pDSwQuY xNJS+6okzGROZ0v9qbT0bszkK9eEmCbQJD3yojNMDbKQsOcCvExyZ8DrDDHOmO4pAGhXmgw Sr5Bc/7ffrbnLG0DLz3MC9Ev8l/5o2SyA/EreDNth+lXoWxIkniHqlObGBPbpwC364wp1SU WdhKjrTf0jqnlmhcvEMew== X-UI-Out-Filterresults: notjunk:1; V01:K0:auIJ8o99ETY=:zSPtb3DQXOmYl77PSxL24U A5/J9/6zPfj/uF1qI2K9Ls9Al9DGnVH8/PELCiTtmIEndiSVn14ZJJUwMXbbJe/gdWGE3ybvH 4S+yk6eJP8PhZUeaf49hjrhgKTgX5HwCwHtIUf7FL3bmeb40I6ZCSu1kRyftk24iD046iShsU XPlv8XC2awXnZrYkkU28xoLTgHtUz7FkUQG9q2kkO+7+JCeYqF1z3jZUgjhpkcVCS702CSNuv CGlv0XSjjHL9TcdMJDT3VLTuv8MUis/n9TnoqhaRjnyH55j4EM5LosBjDLCpBl1RFJ/qwYE89 ykSyK52cwGorA3GdkckVeP7uOmC9FrnRc9AxvpBwkBuftWmsKQSMer0lxANgU9joY1n7qUxay WtOIlHOKjHNECbICHeqz3G/8OBzSj7E+Gg0XvpVd0+gUrOMegxirjc8hJyIbCYA3OHdF/1PqX +Vb/m2x9MCTHtIqiLxjLPJitTqgPKGHDczgPzgpZxYSlPu+a5IuIAcwGVXi2zhrkrlSpnAK/F RLbhalLfLQSJ7L9wB6zXsD0CszyDZ3m0tAZWeF9VdBixR19DM+xuS8uzF/QRtTUE28NoTqzHO zmKPHr4AShsLjJ3UdRmoFUXkYGiaUzxZ03zTPvKwv8M3Gsc7rxbBjXH4LKAWyDSuRdIziIUzD eJj9Y30lhXzscXGo37Ail/2zpGBbCG/XMVw07W8DGDRAm4z/Eeb8xDv/oKmA/1mhJmYMk0Qdw f7PyEQM2XMkj3CrUh4k0VbJth/4ZMfzAgMwkqUkb7TQFK0EehkPo/IXxAWB87b3iLB/4O+m9y qCaXV4aFMW3X70EqoIBKC2+Oq429cE/xZXCUsHf+mwec5m6U8w= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Thu, 8 Feb 2018 15:08:39 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/gma500/framebuffer.c | 3 +-- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 3ff320f3ff47..ad96a542d137 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -525,11 +525,10 @@ static int psb_fbdev_destroy(struct drm_device *dev, struct psb_fbdev *fbdev) int psb_fbdev_init(struct drm_device *dev) { - struct psb_fbdev *fbdev; struct drm_psb_private *dev_priv = dev->dev_private; int ret; + struct psb_fbdev *fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); - fbdev = kzalloc(sizeof(struct psb_fbdev), GFP_KERNEL); if (!fbdev) return -ENOMEM; diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c index d9a6d54b6641..dbc58e5130bb 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c @@ -637,11 +637,11 @@ void oaktrail_hdmi_init(struct drm_device *dev, struct drm_connector *connector; struct drm_encoder *encoder; - gma_encoder = kzalloc(sizeof(struct gma_encoder), GFP_KERNEL); + gma_encoder = kzalloc(sizeof(*gma_encoder), GFP_KERNEL); if (!gma_encoder) return; - gma_connector = kzalloc(sizeof(struct gma_connector), GFP_KERNEL); + gma_connector = kzalloc(sizeof(*gma_connector), GFP_KERNEL); if (!gma_connector) goto failed_connector; @@ -689,7 +689,7 @@ void oaktrail_hdmi_setup(struct drm_device *dev) if (!pdev) return; - hdmi_dev = kzalloc(sizeof(struct oaktrail_hdmi_dev), GFP_KERNEL); + hdmi_dev = kzalloc(sizeof(*hdmi_dev), GFP_KERNEL); if (!hdmi_dev) goto out;