| Message ID | 9bf64023-cc27-435a-a1bf-f11816229d49@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Series with core improvements/refactorings | expand |
On Sun, Sep 08, 2024 at 02:14:43PM GMT, Heiner Kallweit wrote: > This device type is set but not used, so remove it. Please describe how it was used and why you consider it to be unused now. Hint: d14d2a8453d6 ("drm: Remove dev_pm_ops from drm_class"). > Whilst we're at it, constify device type drm_connector. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Whilst we are at it => separate commits, please. > --- > drivers/gpu/drm/drm_sysfs.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index b73c589c5..45a1c864a 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -50,11 +50,7 @@ * drm_connector_unregister(). */ -static struct device_type drm_sysfs_device_minor = { - .name = "drm_minor" -}; - -static struct device_type drm_sysfs_device_connector = { +static const struct device_type drm_sysfs_device_connector = { .name = "drm_connector", }; @@ -517,7 +513,6 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor) kdev->devt = MKDEV(DRM_MAJOR, minor->index); kdev->class = &drm_class; - kdev->type = &drm_sysfs_device_minor; } kdev->parent = minor->dev->dev;
This device type is set but not used, so remove it. Whilst we're at it, constify device type drm_connector. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/drm_sysfs.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)