From patchwork Mon Aug 21 14:45:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Murzin X-Patchwork-Id: 9914027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A6549608A6 for ; Tue, 22 Aug 2017 00:39:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C9B828616 for ; Tue, 22 Aug 2017 00:39:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9153E28806; Tue, 22 Aug 2017 00:39:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B0F3728806 for ; Tue, 22 Aug 2017 00:39:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 429426E33B; Tue, 22 Aug 2017 00:36:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id B40AA6E040 for ; Mon, 21 Aug 2017 14:45:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 06C8980D; Mon, 21 Aug 2017 07:45:43 -0700 (PDT) Received: from [10.1.79.19] (unknown [10.1.79.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57F353F540; Mon, 21 Aug 2017 07:45:41 -0700 (PDT) Subject: Re: [PATCH] drm: hdlcd: allow HDLCD to be used without interrupt To: Russell King - ARM Linux , Liviu Dudau References: <20170726102748.GM31807@n2100.armlinux.org.uk> From: Vladimir Murzin Message-ID: <9cdccb9c-83c5-5867-06a5-3b344102d232@arm.com> Date: Mon, 21 Aug 2017 15:45:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: X-Mailman-Approved-At: Tue, 22 Aug 2017 00:36:37 +0000 Cc: Mark Rutland , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Mali DP Maintainers , linux-arm-kernel@lists.infradead.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 10/08/17 13:15, Vladimir Murzin wrote: > On 26/07/17 11:27, Russell King - ARM Linux wrote: >> I suspect the above failure is down to either (a) not having enough >> memory available to allocate a 1920x1080 frame buffer, or (b) not >> (yet) being able to program the hdlcd pixel clock for this platform, >> which is currently hard-coded in DT at 23.75MHz. > > Given it is NOMMU it is likely (a). Usually, tweaking FORCE_MAX_ZONEORDER > helped me in such cases. Ok, with CONFIG_FORCE_MAX_ZONEORDER=12 I see [ 5.242423] [drm] found ARM HDLCD version r0p0 [ 5.493835] tda998x 2-0070: found TDA19988 [ 5.527771] hdlcd 40205000.hdlcd: bound 2-0070 (ops 0x1470f8) [ 5.535819] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 5.543478] [drm] No driver support for vblank timestamp query. [ 7.443189] hdlcd 40205000.hdlcd: fb0: frame buffer device [ 7.501975] [drm] Initialized hdlcd 1.0.0 20151021 for 40205000.hdlcd on minor 0 when display is connected. To make fb-test [1] happy I had to apply following diff: (The only user of FB_PROVIDE_GET_FB_UNMAPPED_AREA is NOMMU only drivers/gpu/drm/stm/) However, I do not see anything on the screen. I'm probably missing something obvious, so if you have an idea, please let me know and I can test the patch. [1] https://github.com/prpplague/fb-test-app.git Thanks Vladimir > > Cheers > Vladimir > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 9a18e1b..d4cb1b1 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -10,6 +10,7 @@ config DRM_HDLCD select DRM_ARM select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER + select FB_PROVIDE_GET_FB_UNMAPPED_AREA if !MMU help Choose this option if you have an ARM High Definition Colour LCD controller.