From patchwork Sun Jan 16 11:42:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Airlie X-Patchwork-Id: 481931 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0GBgl8D001336 for ; Sun, 16 Jan 2011 11:43:07 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F14F9E7CF for ; Sun, 16 Jan 2011 03:42:47 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-vw0-f49.google.com (mail-vw0-f49.google.com [209.85.212.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B2E779E75C for ; Sun, 16 Jan 2011 03:42:38 -0800 (PST) Received: by vws5 with SMTP id 5so1647861vws.36 for ; Sun, 16 Jan 2011 03:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6Z3XZTw8R7V7PrqXXiHQ7j9iAa/NDB+t8sfcCV3UBC4=; b=x8LHEY+3TAXThUVRwA29bVPIeFmKBEOMOPSM2meteuAjdfcOOS5aEDTX3vNIgWTJel 2gEHuE/zuWZ81uuiN/lFem+LJ8s8pO9MCbIvTxeT9v/iHG9VBqeKE9lhBT76/KFsb7jU t6IqPrXuX3J34cEcIVr+yY4Flh75uvbyElQ30= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=djgSEVq337IaA5y8BorHMyQbxgjikytGk6ukZkO3vklIBJOGKnTG6/L6SnhoEiUAPi lh/eH1rBTuTTLOHG4w35ovK7594vgZi8gQVPMWXZaqU3Mij3fEd5MsgrU7aYidB/ji7M QnA5Zy7uFdkr8f5xJWTpjvj82ecLX5TQmMLQU= MIME-Version: 1.0 Received: by 10.220.195.12 with SMTP id ea12mr1014946vcb.7.1295178157921; Sun, 16 Jan 2011 03:42:37 -0800 (PST) Received: by 10.220.51.68 with HTTP; Sun, 16 Jan 2011 03:42:37 -0800 (PST) In-Reply-To: <20110116111809.GD2456@legolas.emea.dhcp.ti.com> References: <1295174783-4099-1-git-send-email-balbi@ti.com> <0d30dc$kp159h@orsmga001.jf.intel.com> <20110116111616.GC2456@legolas.emea.dhcp.ti.com> <20110116111809.GD2456@legolas.emea.dhcp.ti.com> Date: Sun, 16 Jan 2011 21:42:37 +1000 Message-ID: Subject: Re: [PATCH 1/2] drm: fixup headers_check From: Dave Airlie To: balbi@ti.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 16 Jan 2011 11:43:07 +0000 (UTC) From 1222ad4188aa2a6046da931487543507a59b7fac Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Sun, 16 Jan 2011 21:35:10 +1000 Subject: [PATCH] drm: add comments to stop pointless patches. How about you fix the headers script to be recursive? Signed-off-by: Dave Airlie --- include/drm/drm_mode.h | 3 +++ include/drm/i915_drm.h | 1 + include/drm/mga_drm.h | 1 + include/drm/radeon_drm.h | 1 + include/drm/via_drm.h | 1 + 5 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h index 0fc7397..7a1f6c5 100644 --- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h @@ -27,6 +27,9 @@ #ifndef _DRM_MODE_H #define _DRM_MODE_H +/* this file doesn't need linux/types.h included */ +#include "drm.h" + #define DRM_DISPLAY_INFO_LEN 32 #define DRM_CONNECTOR_NAME_LEN 32 #define DRM_DISPLAY_MODE_LEN 32 diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 0039f1f..0da0420 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -27,6 +27,7 @@ #ifndef _I915_DRM_H_ #define _I915_DRM_H_ +/* this file doesn't need linux/types.h included */ #include "drm.h" /* Please note that modifications to all structs defined here are diff --git a/include/drm/mga_drm.h b/include/drm/mga_drm.h index c16097f..41b4081 100644 --- a/include/drm/mga_drm.h +++ b/include/drm/mga_drm.h @@ -35,6 +35,7 @@ #ifndef __MGA_DRM_H__ #define __MGA_DRM_H__ +/* this file doesn't need linux/types.h included */ #include "drm.h" /* WARNING: If you change any of these defines, make sure to change the diff --git a/include/drm/radeon_drm.h b/include/drm/radeon_drm.h index e95a86b..c33f656 100644 --- a/include/drm/radeon_drm.h +++ b/include/drm/radeon_drm.h @@ -33,6 +33,7 @@ #ifndef __RADEON_DRM_H__ #define __RADEON_DRM_H__ +/* this file doesn't need linux/types.h included */ #include "drm.h" /* WARNING: If you change any of these defines, make sure to change the diff --git a/include/drm/via_drm.h b/include/drm/via_drm.h index fd11a5b..ccde589 100644 --- a/include/drm/via_drm.h +++ b/include/drm/via_drm.h @@ -24,6 +24,7 @@ #ifndef _VIA_DRM_H_ #define _VIA_DRM_H_ +/* this file doesn't need linux/types.h included */ #include "drm.h" /* WARNING: These defines must be the same as what the Xserver uses. -- 1.7.2.3