| Message ID | BY5PR02MB700935F5817128CB7C3991CDD9E09@BY5PR02MB7009.namprd02.prod.outlook.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: nt36672a: add backlight support | expand |
On 2022-04-01 05:48:08, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > index 231f371901e8..6d6ce42787e2 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c > @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) > > drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); > > + ret = drm_panel_of_backlight(&pinfo->base); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to get backlight\n"); > + > drm_panel_add(&pinfo->base); > > return 0; > -- > 2.35.1 >
On Fri, 1 Apr 2022 05:48:08 +0530, Joel Selvaraj wrote: > Add support for backlight. This panel supports backlight control > through the QCOM WLED driver in Xiaomi Poco F1 device. > > Applied, thanks! [3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: enable qcom wled backlight and link to panel commit: 89561886191c0dcb6ce1491f14552eac16e14a80 Best regards,
Hi, I can see that the dts changes from this patch series has been applied to 5.19-rc1 release. However, this patch that has the related change to the panel driver, is not applied in the 5.19-rc1 release. Any particular reason why it's not picked up? or just that, it got missed out? Kindly let me know if changes are required from my end. With Regards, Joel Selvaraj
Hi Joel, On Wed, 8 Jun 2022 at 00:01, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi, > > I can see that the dts changes from this patch series has been applied > to 5.19-rc1 release. However, this patch that has the related change to > the panel driver, is not applied in the 5.19-rc1 release. Any particular > reason why it's not picked up? or just that, it got missed out? Kindly > let me know if changes are required from my end. This is entirely my fault - It somehow missed my radar, and I didn't queue it up. I will push it via drm-misc tree tonight. Apologies again! > > With Regards, > Joel Selvaraj Best, Sumit.
Hi Sumit, On 08/06/22 22:00, Sumit Semwal wrote: > This is entirely my fault - It somehow missed my radar, and I didn't > queue it up. I will push it via drm-misc tree tonight. Apologies > again! No problem. Thanks for the update! So it will land on upcoming 5.19-rcs or 5.20-rc? > Best, > Sumit. Best Regards, Joel Selvaraj
Hi Joel, On Wed, 8 Jun 2022 at 22:10, Joel Selvaraj <jo@jsfamily.in> wrote: > > Hi Sumit, > > On 08/06/22 22:00, Sumit Semwal wrote: > > This is entirely my fault - It somehow missed my radar, and I didn't > > queue it up. I will push it via drm-misc tree tonight. Apologies > > again! > > No problem. Thanks for the update! So it will land on upcoming 5.19-rcs > or 5.20-rc? Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? > > > Best, > > Sumit. > > Best Regards, > Joel Selvaraj Best, Sumit.
Hi Sumit, On 08/06/22 23:22, Sumit Semwal wrote: > Not for 5.19-rcs for sure, but I think it should make it for 5.20-rcs? Ok. No problem. Thanks. > Best, > Sumit. Best Regards, Joel Selvaraj
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c index 231f371901e8..6d6ce42787e2 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -628,6 +628,10 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo) drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI); + ret = drm_panel_of_backlight(&pinfo->base); + if (ret) + return dev_err_probe(dev, ret, "Failed to get backlight\n"); + drm_panel_add(&pinfo->base); return 0;
Add support for backlight. This panel supports backlight control through the QCOM WLED driver in Xiaomi Poco F1 device. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 4 ++++ 1 file changed, 4 insertions(+)