| Message ID | CADnq5_N8GO8pmOLaZszMUxt6ZA1OZyVHY3O95kN8r9FFPOncVQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
That did it. a716d5540346 (HEAD -> amd-staging-drm-next) drm/amdgpu: don't skip attributes when powerplay is enabled 9f896d936c9d (origin/amd-staging-drm-next) drm/amdgpu: fix VCE buffer placement restrictions v2 ca9b5d953735 drm/amdgpu: align GTT start to 4GB v2 52364b9f0226 drm/amdgpu: remove VRAM size reduction v2 95d8c587cba5 drm/amd/pp: fix typecast error in powerplay. [-] amdgpu-pci-0100 Adapter: PCI adapter fan1: 881 RPM temp1: +29.0°C (crit = +0.0°C, hyst = +0.0°C) Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de> Thank you very much Alex! Dieter Am 20.11.2017 23:57, schrieb Alex Deucher: > On Sun, Oct 8, 2017 at 10:31 PM, Dieter Nützel <Dieter@nuetzel-hh.de> > wrote: >> OK, got it but can't revert the commit clean. >> >> amdgpu-pci-0100 >> Adapter: PCI adapter >> fan1: 873 RPM >> temp1: +26.0°C (crit = +0.0°C, hyst = +0.0°C) >> >> SOURCE/amd-staging-drm-next> git bisect good >> 0944c350c8eddf4064e7abb881dd245032fdfa23 is the first bad commit >> commit 0944c350c8eddf4064e7abb881dd245032fdfa23 >> Author: Rex Zhu <Rex.Zhu@amd.com> >> Date: Mon Sep 25 18:51:50 2017 +0800 >> >> drm/amdgpu: delete pp_enable in adev >> >> amdgpu not care powerplay or dpm is enabled. >> just check ip functions and pp functions >> >> Change-Id: Iaac75d45170ef9b20e212465f837eaaa798365bd >> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> >> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> >> >> :040000 040000 72361654709479890586e383ec73088e535a1cf5 >> 2b6d5a75ffc3b6fd48c63e79bf28faddcc734918 M drivers > > I think the attached patch should fix it. > > Alex > >> >> Greetings, >> Dieter >> >> >> >> Am 09.10.2017 02:19, schrieb Dieter Nützel: >>> >>> Sorry Rex, >>> >>> after return from our vacation, >>> I've tested latest amd-staging-drm-next (e5f6a57e350a) >>> but it is NOT solved on my RX580. >>> I'll try bisecting if I find some more time in the coming days. >>> >>> amdgpu-pci-0100 >>> Adapter: PCI adapter >>> temp1: +27.0°C (crit = +0.0°C, hyst = +0.0°C) >>> >>> 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. >>> [AMD/ATI] Ellesmere [Radeon RX 470/480/570/580] (rev e7) (prog-if 00 >>> [VGA controller]) >>> Subsystem: Sapphire Technology Limited Radeon RX 570 >>> >>> [ 36.740] (--) AMDGPU(0): Chipset: "Radeon RX 580 Series" (ChipID >>> = >>> 0x67df) >>> >>> Thanks, >>> Dieter >>> >>> Am 30.09.2017 05:09, schrieb Zhu, Rex: >>>> >>>> Yes, caused by the commit e37a7b4088da >>>> ("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c") >>>> >>>> Replace error when split patches. >>>> >>>> Have sent the fix patch. >>>> Please review. >>>> >>>> Best Regards >>>> Rex >>>> >>>> >>>> -----Original Message----- >>>> From: Alex Deucher [mailto:alexdeucher@gmail.com] >>>> Sent: Friday, September 29, 2017 10:11 PM >>>> To: Dieter Nützel; Zhu, Rex >>>> Cc: amd-devel; DRI Devel; Wentland, Harry; Michel Dänzer >>>> Subject: Re: [amd-staging-drm-next] regression - no fan info >>>> (sensors) on >>>> RX580 >>>> >>>> Rex, probably related to the recent cleanups in powerplay. >>>> >>>> On Fri, Sep 29, 2017 at 10:09 AM, Dieter Nützel >>>> <Dieter@nuetzel-hh.de> >>>> wrote: >>>>> >>>>> Hello all, >>>>> >>>>> since latest update >>>>> >>>>> 1d7da702e70d3c27408a3bb312c71d6be9f7bebe >>>>> drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible" >>>>> >>>>> I didn't get fan info with my RX580 (Polaris21) any longer. >>>>> >>>>> Worked with this commit: >>>>> >>>>> 786df0b89fe5a0b405d4de0a1ce03003c0743ec3 >>>>> drm/amd/display: fix pflip irq registor for raven >>>>> >>>>> Sorry, I do not have full time for bisect, because we are on way to >>>>> our vacation. >>>>> >>>>> Maybe in the evening (only a few commits). >>>>> >>>>> Greetings, >>>>> Dieter >>> >>> _______________________________________________ >>> dri-devel mailing list >>> dri-devel@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
From 70d57b480ece67dbb4c54294f5b34549043688ac Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexander.deucher@amd.com>
Date: Mon, 20 Nov 2017 17:49:53 -0500
Subject: [PATCH] drm/amdgpu: don't skip attributes when powerplay is enabled
The function checks non-powerplay structures so regressed when
the pp_enabled check was removed. This should ideally be
implemented similarly for powerplay.
Fixes: 6d07fe7bcae57 ("drm/amdgpu: delete pp_enable in adev")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 3506758349dc..6f56ff606e43 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -945,6 +945,10 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,
struct amdgpu_device *adev = dev_get_drvdata(dev);
umode_t effective_mode = attr->mode;
+ /* no skipping for powerplay */
+ if (adev->powerplay.cgs_device)
+ return effective_mode;
+
/* Skip limit attributes if DPM is not enabled */
if (!adev->pm.dpm_enabled &&
(attr == &sensor_dev_attr_temp1_crit.dev_attr.attr ||
--
2.13.6